From: Nick Mathewson <nickm@torproject.org>
Date: Tue, 6 Nov 2007 14:21:08 +0000 (+0000)
Subject:  r16452@catbus:  nickm | 2007-11-06 09:20:08 -0500
X-Git-Tag: tor-0.2.0.10-alpha~36
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=af60d79f5deee3e6b264049dfa8512f381a8cbc6;p=thirdparty%2Ftor.git

 r16452@catbus:  nickm | 2007-11-06 09:20:08 -0500
 Fix warning about overflow optimization.


svn:r12395
---

diff --git a/src/or/command.c b/src/or/command.c
index 36de2d15cb..834d47e871 100644
--- a/src/or/command.c
+++ b/src/or/command.c
@@ -695,7 +695,7 @@ command_process_link_auth_cell(cell_t *cell, or_connection_t *conn)
     goto err;
   }
   len = ntohs(get_uint16(cell->payload));
-  if (len < 2 || 2+len > CELL_PAYLOAD_SIZE) {
+  if (len < 2 || len > CELL_PAYLOAD_SIZE - 2) {
     log_fn(LOG_PROTOCOL_WARN, LD_OR, "Bad length field (%d) on LINK_AUTH cell;"
            " closing the connection", (int)len);
     goto err;