From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 6 Oct 2023 15:53:13 +0000 (+0200)
Subject: serialize: modernize deserialize_{usec|dual_timestamp}() a bit
X-Git-Tag: v255-rc1~212^2~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=af6321857dc9f0b9c1d58ec2fe4959aebc595c1b;p=thirdparty%2Fsystemd.git

serialize: modernize deserialize_{usec|dual_timestamp}() a bit

Rename the return parameters "ret", and use compound initialization. Add
an assert() on input.
---

diff --git a/src/shared/serialize.c b/src/shared/serialize.c
index d62dfaa2d7a..276e2b7b912 100644
--- a/src/shared/serialize.c
+++ b/src/shared/serialize.c
@@ -320,6 +320,7 @@ int deserialize_usec(const char *value, usec_t *ret) {
         int r;
 
         assert(value);
+        assert(ret);
 
         r = safe_atou64(value, ret);
         if (r < 0)
@@ -328,12 +329,12 @@ int deserialize_usec(const char *value, usec_t *ret) {
         return 0;
 }
 
-int deserialize_dual_timestamp(const char *value, dual_timestamp *t) {
+int deserialize_dual_timestamp(const char *value, dual_timestamp *ret) {
         uint64_t a, b;
         int r, pos;
 
         assert(value);
-        assert(t);
+        assert(ret);
 
         pos = strspn(value, WHITESPACE);
         if (value[pos] == '-')
@@ -353,8 +354,10 @@ int deserialize_dual_timestamp(const char *value, dual_timestamp *t) {
                 /* trailing garbage */
                 return -EINVAL;
 
-        t->realtime = a;
-        t->monotonic = b;
+        *ret = (dual_timestamp) {
+                .realtime = a,
+                .monotonic = b,
+        };
 
         return 0;
 }
diff --git a/src/shared/serialize.h b/src/shared/serialize.h
index decad81de7d..c4f78b3bd9a 100644
--- a/src/shared/serialize.h
+++ b/src/shared/serialize.h
@@ -38,8 +38,8 @@ static inline int serialize_item_tristate(FILE *f, const char *key, int value) {
 int deserialize_read_line(FILE *f, char **ret);
 
 int deserialize_fd(FDSet *fds, const char *value);
-int deserialize_usec(const char *value, usec_t *timestamp);
-int deserialize_dual_timestamp(const char *value, dual_timestamp *t);
+int deserialize_usec(const char *value, usec_t *ret);
+int deserialize_dual_timestamp(const char *value, dual_timestamp *ret);
 int deserialize_environment(const char *value, char ***environment);
 int deserialize_strv(char ***l, const char *value);
 int deserialize_pidref(FDSet *fds, const char *value, PidRef *ret);