From: Sven Wegener <sven.wegener@stealer.net>
Date: Mon, 9 Nov 2015 19:44:32 +0000 (+0100)
Subject: udp: do not leak file descriptor on error
X-Git-Tag: v4.2.1~1619
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b00117ec2a824dfa1f5b6269e06d25bceef4402a;p=thirdparty%2Ftvheadend.git

udp: do not leak file descriptor on error

Additional fixup for 3ed1214 in udp_bind()

Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
---

diff --git a/src/udp.c b/src/udp.c
index 3bf241cb0..3f33b3c4f 100644
--- a/src/udp.c
+++ b/src/udp.c
@@ -184,6 +184,8 @@ udp_bind ( const char *subsystem, const char *name,
     return UDP_FATAL_ERROR;
   }
 
+  uc->fd = fd;
+
   /* Mark reuse address */
   if (setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &reuse, sizeof(reuse))) {
     tvherror(subsystem, "%s - failed to reuse address for socket [%s]",
@@ -287,7 +289,6 @@ udp_bind ( const char *subsystem, const char *name,
     tvhwarn(subsystem, "%s - cannot change UDP tx buffer size [%s]",
             name, strerror(errno));
 
-  uc->fd = fd;
   return uc;
 
 error: