From: Andrew Bartlett <abartlet@samba.org>
Date: Sun, 5 May 2019 23:22:55 +0000 (+1200)
Subject: pidl: Always call PyLong_FromUnsignedLongLong() in ndr_PyLong_FromUnsignedLongLong()
X-Git-Tag: tdb-1.4.1~204
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b0714c70ea52e9a3a1f34d1c3c1642820e6acacf;p=thirdparty%2Fsamba.git

pidl: Always call PyLong_FromUnsignedLongLong() in ndr_PyLong_FromUnsignedLongLong()

The C type is "unsigned long long" so use that always, as the Python type is now always the same.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/pidl/lib/Parse/Pidl/Samba4/Python.pm b/pidl/lib/Parse/Pidl/Samba4/Python.pm
index 4530b113bf6..d01bce28b50 100644
--- a/pidl/lib/Parse/Pidl/Samba4/Python.pm
+++ b/pidl/lib/Parse/Pidl/Samba4/Python.pm
@@ -2323,11 +2323,7 @@ static inline PyObject *ndr_PyLong_FromLongLong(long long v)
 
 static inline PyObject *ndr_PyLong_FromUnsignedLongLong(unsigned long long v)
 {
-	if (v > LONG_MAX) {
-		return PyLong_FromUnsignedLongLong(v);
-	} else {
-		return PyLong_FromLong(v);
-	}
+	return PyLong_FromUnsignedLongLong(v);
 }
 
 ");