From: Darrick J. Wong <djwong@kernel.org>
Date: Mon, 8 Jun 2026 16:58:05 +0000 (-0700)
Subject: mkfs: don't redefine DIRT for protofiles
X-Git-Tag: v7.1.0~14
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b07c386bc60b355c456bc631b885eef38c2d3fa5;p=thirdparty%2Fxfsprogs-dev.git

mkfs: don't redefine DIRT for protofiles

Codex noticed that the mkfs Makefile redefines DIRT to point only to the
xfs_protofile script.  This overrides the more expansive definition in
buildrules; we should use LDIRT instead.

Cc: <linux-xfs@vger.kernel.org> # v6.13.0
Fixes: 6aace700b7b82d ("mkfs: add a utility to generate protofiles")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---

diff --git a/mkfs/Makefile b/mkfs/Makefile
index fb1473324..16793bdb1 100644
--- a/mkfs/Makefile
+++ b/mkfs/Makefile
@@ -25,7 +25,7 @@ LLDLIBS += $(LIBXFS) $(LIBXCMD) $(LIBFROG) $(LIBRT) $(LIBBLKID) \
 	$(LIBUUID) $(LIBINIH) $(LIBURCU) $(LIBPTHREAD)
 LTDEPENDENCIES += $(LIBXFS) $(LIBXCMD) $(LIBFROG)
 LLDFLAGS = -static-libtool-libs
-DIRT = $(XFS_PROTOFILE)
+LDIRT = $(XFS_PROTOFILE)
 
 default: depend $(LTCOMMAND) $(CFGFILES) $(XFS_PROTOFILE)