From: Sébastien Darche <sdarche@efficios.com>
Date: Mon, 29 Sep 2025 14:50:48 +0000 (-0400)
Subject: gdb: make deprecated_show_value_hack use its ui_file parameter
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b091f85b80de2d94a0703d86c1424b1f34fffc47;p=thirdparty%2Fbinutils-gdb.git

gdb: make deprecated_show_value_hack use its ui_file parameter

If a setting does not provide a "show" function, we fall back to the
deprecated_show_value_hack function to print the value in a generic
way. The current version ignores the `file` parameter specifying the
output file in favor of always using gdb_stdout.

To make things consistent with how the values are printed using a
regular show command, the proposed change makes the function use the
ui_file parameter it receives (even though do_show_command passes
gdb_stdout).

Co-Authored-By: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I54028ed654a1fa4d955e6e46f979472c8d98ace9
Approved-By: Andrew Burgess <aburgess@redhat.com>
---

diff --git a/gdb/cli/cli-setshow.c b/gdb/cli/cli-setshow.c
index 8528ac52148..d92d14e7bb4 100644
--- a/gdb/cli/cli-setshow.c
+++ b/gdb/cli/cli-setshow.c
@@ -118,7 +118,7 @@ parse_cli_boolean_value (const char *arg)
 
 
 static void
-deprecated_show_value_hack (struct ui_file *ignore_file,
+deprecated_show_value_hack (struct ui_file *file,
 			    int ignore_from_tty,
 			    struct cmd_list_element *c,
 			    const char *value)
@@ -129,7 +129,7 @@ deprecated_show_value_hack (struct ui_file *ignore_file,
 
   /* Print doc minus "Show " at start.  Tell print_doc_line that
      this is for a 'show value' prefix.  */
-  print_doc_line (gdb_stdout, c->doc + 5, true);
+  print_doc_line (file, c->doc + 5, true);
 
   gdb_assert (c->var.has_value ());
 
@@ -138,17 +138,17 @@ deprecated_show_value_hack (struct ui_file *ignore_file,
     case var_string:
     case var_string_noescape:
     case var_enum:
-      gdb_printf ((" is \"%s\".\n"), value);
+      gdb_printf (file, _(" is \"%s\".\n"), value);
       break;
 
     case var_optional_filename:
     case var_filename:
-      gdb_printf ((" is \"%ps\".\n"),
+      gdb_printf (file, _(" is \"%ps\".\n"),
 		  styled_string (file_name_style.style (), value));
       break;
 
     default:
-      gdb_printf ((" is %s.\n"), value);
+      gdb_printf (file, _(" is %s.\n"), value);
       break;
     }
 }
@@ -747,5 +747,3 @@ cmd_show_list (struct cmd_list_element *list, int from_tty)
 	}
     }
 }
-
-