From: lpsolit%gmail.com <>
Date: Fri, 14 Jul 2006 01:37:08 +0000 (+0000)
Subject: Bug 344448: editparams.cgi doesn't let me clear a group - Patch by Frédéric Buclin... 
X-Git-Tag: bugzilla-2.23.3~268
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b0afe45f807cca40b3c6971859ce0a7b2d59584b;p=thirdparty%2Fbugzilla.git

Bug 344448: editparams.cgi doesn't let me clear a group - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
---

diff --git a/Bugzilla/Config/Common.pm b/Bugzilla/Config/Common.pm
index 9fe648d013..30b484468a 100644
--- a/Bugzilla/Config/Common.pm
+++ b/Bugzilla/Config/Common.pm
@@ -154,6 +154,7 @@ sub check_opsys {
 
 sub check_group {
     my $group_name = shift;
+    return "" unless $group_name;
     my $group = new Bugzilla::Group({'name' => $group_name});
     unless (defined $group) {
         return "Must be an existing group name";
diff --git a/Bugzilla/Config/GroupSecurity.pm b/Bugzilla/Config/GroupSecurity.pm
index 08b202cda6..0235a8cb16 100644
--- a/Bugzilla/Config/GroupSecurity.pm
+++ b/Bugzilla/Config/GroupSecurity.pm
@@ -94,6 +94,7 @@ sub get_param_list {
 
 sub _get_all_group_names {
     my @group_names = map {$_->name} Bugzilla::Group::get_all_groups();
+    unshift(@group_names, '');
     return \@group_names;
 }
 1;