From: Jeremy Allison <jra@samba.org>
Date: Tue, 22 Mar 2005 21:43:51 +0000 (+0000)
Subject: r5973: Fix up overwrite of last 2 bytes on clilist (could cause coredump).
X-Git-Tag: samba-misc-tags/initial-v3-0-unstable~5062
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b0de2d761f6697ca1f4859ba098af6162ab42027;p=thirdparty%2Fsamba.git

r5973: Fix up overwrite of last 2 bytes on clilist (could cause coredump).
Jeremy.
---

diff --git a/source/libsmb/clilist.c b/source/libsmb/clilist.c
index 5138bca8df1..33bf32bb94f 100644
--- a/source/libsmb/clilist.c
+++ b/source/libsmb/clilist.c
@@ -281,14 +281,11 @@ int cli_list_new(struct cli_state *cli,const char *Mask,uint16 attribute,
 			dirlist = tdl;
 		}
 
-		/* put in a length for the last entry, to ensure we can chain entries 
-		   into the next packet */
+		/* we might need the lastname for continuations */
 		for (p2=p,i=0;i<ff_searchcount;i++) {
 			p2 += interpret_long_filename(cli,info_level,p2,&finfo);
 		}
-		SSVAL(p2,0,data_len - PTR_DIFF(p2,p));
 
-		/* we might need the lastname for continuations */
 		if (ff_lastname > 0) {
 			pstrcpy(mask, finfo.name);
 		} else {