From: Sergey B Kirpichev <2155800+skirpichev@users.noreply.github.com> Date: Mon, 17 May 2021 07:20:02 +0000 (+0300) Subject: bpo-44154: optimize Fraction pickling (GH-26186) X-Git-Tag: v3.11.0a1~1098 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b102dd598dd2666b72e93ae53ae813d1e88f186c;p=thirdparty%2FPython%2Fcpython.git bpo-44154: optimize Fraction pickling (GH-26186) --- diff --git a/Lib/fractions.py b/Lib/fractions.py index 96047beb4546..64a8959d7d48 100644 --- a/Lib/fractions.py +++ b/Lib/fractions.py @@ -735,7 +735,7 @@ class Fraction(numbers.Rational): # support for pickling, copy, and deepcopy def __reduce__(self): - return (self.__class__, (str(self),)) + return (self.__class__, (self._numerator, self._denominator)) def __copy__(self): if type(self) == Fraction: diff --git a/Lib/test/test_fractions.py b/Lib/test/test_fractions.py index b92552531d6b..949ddd907286 100644 --- a/Lib/test/test_fractions.py +++ b/Lib/test/test_fractions.py @@ -10,6 +10,7 @@ import functools import sys import unittest from copy import copy, deepcopy +import pickle from pickle import dumps, loads F = fractions.Fraction @@ -691,7 +692,8 @@ class FractionTest(unittest.TestCase): def test_copy_deepcopy_pickle(self): r = F(13, 7) dr = DummyFraction(13, 7) - self.assertEqual(r, loads(dumps(r))) + for proto in range(0, pickle.HIGHEST_PROTOCOL + 1): + self.assertEqual(r, loads(dumps(r, proto))) self.assertEqual(id(r), id(copy(r))) self.assertEqual(id(r), id(deepcopy(r))) self.assertNotEqual(id(dr), id(copy(dr))) diff --git a/Misc/NEWS.d/next/Library/2021-05-17-07-24-24.bpo-44154.GRI5bf.rst b/Misc/NEWS.d/next/Library/2021-05-17-07-24-24.bpo-44154.GRI5bf.rst new file mode 100644 index 000000000000..3ec326e875ec --- /dev/null +++ b/Misc/NEWS.d/next/Library/2021-05-17-07-24-24.bpo-44154.GRI5bf.rst @@ -0,0 +1 @@ +Optimize :class:`fractions.Fraction` pickling for large components.