From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Thu, 7 Mar 2019 23:12:00 +0000 (+1300)
Subject: ldb_dn: free dn components on explode failure
X-Git-Tag: tdb-1.4.2~327
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b136f153b83d80a91ec9d5350fdf08412d881964;p=thirdparty%2Fsamba.git

ldb_dn: free dn components on explode failure

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
---

diff --git a/lib/ldb/common/ldb_dn.c b/lib/ldb/common/ldb_dn.c
index eccb4a0ce4b..23a817edf65 100644
--- a/lib/ldb/common/ldb_dn.c
+++ b/lib/ldb/common/ldb_dn.c
@@ -340,7 +340,7 @@ static bool ldb_dn_explode(struct ldb_dn *dn)
 	/* Components data space is allocated here once */
 	data = talloc_array(dn->components, char, strlen(parse_dn) + 1);
 	if (!data) {
-		return false;
+		goto failed;
 	}
 
 	p = parse_dn;