From: Serhiy Storchaka <storchaka@gmail.com>
Date: Mon, 27 Nov 2023 17:35:52 +0000 (+0200)
Subject: gh-111789: Use PyDict_GetItemRef() in Modules/_csv.c (gh-112073)
X-Git-Tag: v3.13.0a3~627
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b14e5df120ca8ce968a67df2e00e7a764dd703a0;p=thirdparty%2FPython%2Fcpython.git

gh-111789: Use PyDict_GetItemRef() in Modules/_csv.c (gh-112073)
---

diff --git a/Modules/_csv.c b/Modules/_csv.c
index 714fbef08d22..ae6b6457ffad 100644
--- a/Modules/_csv.c
+++ b/Modules/_csv.c
@@ -160,15 +160,9 @@ static PyObject *
 get_dialect_from_registry(PyObject *name_obj, _csvstate *module_state)
 {
     PyObject *dialect_obj;
-
-    dialect_obj = PyDict_GetItemWithError(module_state->dialects, name_obj);
-    if (dialect_obj == NULL) {
-        if (!PyErr_Occurred())
-            PyErr_Format(module_state->error_obj, "unknown dialect");
+    if (PyDict_GetItemRef(module_state->dialects, name_obj, &dialect_obj) == 0) {
+        PyErr_SetString(module_state->error_obj, "unknown dialect");
     }
-    else
-        Py_INCREF(dialect_obj);
-
     return dialect_obj;
 }