From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Tue, 11 Jan 2022 23:09:22 +0000 (-0800) Subject: bpo-46347: Fix memory leak in PyEval_EvalCodeEx. (GH-30546) X-Git-Tag: v3.10.2~4 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b1a94f1fab7c0aee0705483616a1b2c3f2713c00;p=thirdparty%2FPython%2Fcpython.git bpo-46347: Fix memory leak in PyEval_EvalCodeEx. (GH-30546) First introduced in 0332e569c12d3dc97171546c6dc10e42c27de34b (cherry picked from commit 607d8a838f29ad3c4c4e85b39f338dade5f9cafe) Co-authored-by: Yury Selivanov --- diff --git a/Misc/NEWS.d/next/Core and Builtins/2022-01-11-13-57-00.bpo-46347.Gd8M-S.rst b/Misc/NEWS.d/next/Core and Builtins/2022-01-11-13-57-00.bpo-46347.Gd8M-S.rst new file mode 100644 index 000000000000..fc12d6ba146c --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2022-01-11-13-57-00.bpo-46347.Gd8M-S.rst @@ -0,0 +1 @@ +Fix memory leak in PyEval_EvalCodeEx. diff --git a/Python/ceval.c b/Python/ceval.c index 8ad1713b78c0..e906076e27e5 100644 --- a/Python/ceval.c +++ b/Python/ceval.c @@ -5132,16 +5132,9 @@ PyEval_EvalCodeEx(PyObject *_co, PyObject *globals, PyObject *locals, } allargs = newargs; } - PyObject **kwargs = PyMem_Malloc(sizeof(PyObject *)*kwcount); - if (kwargs == NULL) { - res = NULL; - Py_DECREF(kwnames); - goto fail; - } for (int i = 0; i < kwcount; i++) { Py_INCREF(kws[2*i]); PyTuple_SET_ITEM(kwnames, i, kws[2*i]); - kwargs[i] = kws[2*i+1]; } PyFrameConstructor constr = { .fc_globals = globals,