From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Wed, 19 Jul 2023 11:34:54 +0000 (-0700)
Subject: [3.12] gh-104090: Fix unittest collectedDurations resources leak (GH-106795) (#106888)
X-Git-Tag: v3.12.0rc1~132
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b1c50b80a6197ba1e41539ec0984a9925956cc1d;p=thirdparty%2FPython%2Fcpython.git

[3.12] gh-104090: Fix unittest collectedDurations resources leak (GH-106795) (#106888)

gh-104090: Fix unittest collectedDurations resources leak (GH-106795)
(cherry picked from commit 70b961ed93f67e34d0624e178f6029c886afaeee)

Co-authored-by: Yonatan Bitton <bityob@gmail.com>
---

diff --git a/Lib/unittest/result.py b/Lib/unittest/result.py
index 7757dba9670b..3ace0a5b7bf2 100644
--- a/Lib/unittest/result.py
+++ b/Lib/unittest/result.py
@@ -166,7 +166,8 @@ class TestResult(object):
         """
         # support for a TextTestRunner using an old TestResult class
         if hasattr(self, "collectedDurations"):
-            self.collectedDurations.append((test, elapsed))
+            # Pass test repr and not the test object itself to avoid resources leak
+            self.collectedDurations.append((str(test), elapsed))
 
     def wasSuccessful(self):
         """Tells whether or not this result was a success."""
diff --git a/Misc/NEWS.d/next/Tests/2023-07-16-02-57-08.gh-issue-104090.cKtK7g.rst b/Misc/NEWS.d/next/Tests/2023-07-16-02-57-08.gh-issue-104090.cKtK7g.rst
new file mode 100644
index 000000000000..5cc6c5bbe154
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2023-07-16-02-57-08.gh-issue-104090.cKtK7g.rst
@@ -0,0 +1 @@
+Avoid creating a reference to the test object in :meth:`~unittest.TestResult.collectedDurations`.