From: Christian Ambach Date: Fri, 27 Jul 2012 13:09:18 +0000 (+0200) Subject: s4:libcli/smb2/write correct error checking X-Git-Tag: ldb-1.1.10~88 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b20fb153e1f20a2c6bdbf71d91858e8d2b1c4712;p=thirdparty%2Fsamba.git s4:libcli/smb2/write correct error checking Server might return STATUS_BUFFER_OVERFLOW, which is not caught by NT_STATUS_IS_ERR Autobuild-User(master): Christian Ambach Autobuild-Date(master): Mon Aug 6 20:01:01 CEST 2012 on sn-devel-104 --- diff --git a/source4/libcli/smb2/write.c b/source4/libcli/smb2/write.c index bc283370d75..62ffe2ecf28 100644 --- a/source4/libcli/smb2/write.c +++ b/source4/libcli/smb2/write.c @@ -58,7 +58,7 @@ struct smb2_request *smb2_write_send(struct smb2_tree *tree, struct smb2_write * NTSTATUS smb2_write_recv(struct smb2_request *req, struct smb2_write *io) { if (!smb2_request_receive(req) || - smb2_request_is_error(req)) { + !smb2_request_is_ok(req)) { return smb2_request_destroy(req); }