From: Eric Wong <e@80x24.org>
Date: Mon, 27 Oct 2025 17:39:41 +0000 (+0000)
Subject: t/thread-cycle: note Mail::Thread is dev-only
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b23590a2c6b56142ffa5a343ca1208db002e8204;p=thirdparty%2Fpublic-inbox.git

t/thread-cycle: note Mail::Thread is dev-only

We haven't used Mail::Thread in WWW since 2016, so don't confuse
users about it being missing when they see test suite results.
---

diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index 46bfca585..16b0083bd 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -296,7 +296,7 @@ sub require_mods (@) {
 		return;
 	}
 	my $m = join(', ', @need)." missing for $0";
-	$m =~ s/\bEmail::MIME\b/Email::MIME (development purposes only)/;
+	$m =~ s/\b(Email::MIME|Mail::Thread)\b/$1 (dev purposes only)/;
 	skip($m, $maybe) if $maybe;
 	plan(skip_all => $m)
 }
diff --git a/t/thread-cycle.t b/t/thread-cycle.t
index 1e5dfb51a..e04062e53 100644
--- a/t/thread-cycle.t
+++ b/t/thread-cycle.t
@@ -61,7 +61,7 @@ my ($simples, $smsgs) = $make_objs->(
 my $st = thread_to_s($smsgs);
 
 SKIP: {
-	skip 'Mail::Thread missing', 1 unless $mt;
+	require_mods 'Mail::Thread', 1;
 	check_mt($st, $simples, 'Mail::Thread output matches');
 }
 
@@ -81,14 +81,14 @@ my @backwards = (
 ($simples, $smsgs) = $make_objs->(@backwards);
 my $backward = thread_to_s($smsgs);
 SKIP: {
-	skip 'Mail::Thread missing', 1 unless $mt;
+	require_mods 'Mail::Thread', 1;
 	check_mt($backward, $simples, 'matches Mail::Thread backwards');
 }
 ($simples, $smsgs) = $make_objs->(reverse @backwards);
 my $forward = thread_to_s($smsgs);
 unless ('Mail::Thread sorts by Date') {
 	SKIP: {
-		skip 'Mail::Thread missing', 1 unless $mt;
+		require_mods 'Mail::Thread', 1;
 		check_mt($forward, $simples, 'matches Mail::Thread forwards');
 	}
 }