From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Tue, 22 Aug 2023 10:00:07 +0000 (-0700)
Subject: [3.12] Fix test_generators: save/restore warnings filters (GH-108246) (#108249)
X-Git-Tag: v3.12.0rc2~94
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b26a7b78c9658a9b888f56ce3dc8cfae127d1eca;p=thirdparty%2FPython%2Fcpython.git

[3.12] Fix test_generators: save/restore warnings filters (GH-108246) (#108249)

Fix test_generators: save/restore warnings filters (GH-108246)

Previously, depending on existing filters, the test
could modify the warnings and so fail as "env changed".
(cherry picked from commit 531930f47f6b2a548d31e62cb4ad3e215a24bf53)

Co-authored-by: Victor Stinner <vstinner@python.org>
---

diff --git a/Lib/test/test_generators.py b/Lib/test/test_generators.py
index 31680b5a92e0..1ee9958445bf 100644
--- a/Lib/test/test_generators.py
+++ b/Lib/test/test_generators.py
@@ -2176,6 +2176,7 @@ caught ValueError ()
 caught ValueError (xyz)
 
 >>> import warnings
+>>> old_filters = warnings.filters.copy()
 >>> warnings.filterwarnings("ignore", category=DeprecationWarning)
 
 # Filter DeprecationWarning: regarding the (type, val, tb) signature of throw().
@@ -2249,8 +2250,7 @@ Traceback (most recent call last):
   ...
 ValueError: 7
 
->>> warnings.filters.pop(0)
-('ignore', None, <class 'DeprecationWarning'>, None, 0)
+>>> warnings.filters[:] = old_filters
 
 # Re-enable DeprecationWarning: the (type, val, tb) exception representation is deprecated,
 #                               and may be removed in a future version of Python.