From: Ralph Boehme Date: Mon, 6 May 2019 12:18:27 +0000 (+0200) Subject: s3:mdssvc: close mdssvc rpc command must return in handle X-Git-Tag: tdb-1.4.2~201 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b2bf13ecf7b5406665f27487cb892e4f15fb28c4;p=thirdparty%2Fsamba.git s3:mdssvc: close mdssvc rpc command must return in handle Checked against macOS mdssvc. Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison --- diff --git a/selftest/knownfail.d/samba3.rpc b/selftest/knownfail.d/samba3.rpc index bafc9c3ece0..103c99436f1 100644 --- a/selftest/knownfail.d/samba3.rpc +++ b/selftest/knownfail.d/samba3.rpc @@ -1,2 +1 @@ -^samba3.rpc.mdssvc.rpccmd.close\(fileserver\) ^samba3.rpc.mdssvc.mdscmd.fetch_unknown_cnid\(fileserver\) diff --git a/source3/rpc_server/mdssvc/srv_mdssvc_nt.c b/source3/rpc_server/mdssvc/srv_mdssvc_nt.c index 9e869dd3427..0e8e9c68bd7 100644 --- a/source3/rpc_server/mdssvc/srv_mdssvc_nt.c +++ b/source3/rpc_server/mdssvc/srv_mdssvc_nt.c @@ -317,9 +317,9 @@ void _mdssvc_close(struct pipes_struct *p, struct mdssvc_close *r) DEBUG(10, ("%s: path: %s\n", __func__, mds_ctx->spath)); + *r->out.out_handle = r->in.in_handle; close_policy_hnd(p, &r->in.in_handle); - ZERO_STRUCTP(r->out.out_handle); *r->out.status = 0; return;