From: Sebastian Hahn <sebastian@torproject.org>
Date: Sun, 15 Aug 2010 19:02:01 +0000 (+0200)
Subject: Fix a memory leak in dirvote_compute_consensuses()
X-Git-Tag: tor-0.2.2.15-alpha~17^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b2dcff5766cdf33799659e667a06e109d17b6eb9;p=thirdparty%2Ftor.git

Fix a memory leak in dirvote_compute_consensuses()
---

diff --git a/changes/bug1831 b/changes/bug1831
index 6c504dadbc..72f7d21856 100644
--- a/changes/bug1831
+++ b/changes/bug1831
@@ -3,3 +3,6 @@
       Bugfix on 0.2.2.14-alpha; fixes bug 1831 partially.
     - Fix a memory leak in dirvote_add_signatures_to_pending_consensus(). 
       Bugfix on 0.2.2.6-alpha; fixes bug 1831 partially.
+    - Fix a memory leak in dirvote_compute_consensuses().
+      Bugfix on 0.2.0.3-alpha; fixes bug 1831 partially.
+
diff --git a/src/or/dirvote.c b/src/or/dirvote.c
index 0042934c4a..925f57f6e8 100644
--- a/src/or/dirvote.c
+++ b/src/or/dirvote.c
@@ -2942,6 +2942,7 @@ dirvote_compute_consensuses(void)
                                strlen(pending_consensus_signatures), 0);
   log_notice(LD_DIR, "Signature(s) posted.");
 
+  smartlist_free(votes);
   return 0;
  err:
   smartlist_free(votes);
@@ -3138,7 +3139,7 @@ void
 dirvote_free_all(void)
 {
   dirvote_clear_votes(1);
-  /* now empty as a result of clear_pending_votes. */
+  /* now empty as a result of dirvote_clear_votes(). */
   smartlist_free(pending_vote_list);
   pending_vote_list = NULL;
   smartlist_free(previous_vote_list);
@@ -3147,7 +3148,7 @@ dirvote_free_all(void)
   dirvote_clear_pending_consensuses();
   tor_free(pending_consensus_signatures);
   if (pending_consensus_signature_list) {
-    /* now empty as a result of clear_pending_votes. */
+    /* now empty as a result of dirvote_clear_votes(). */
     smartlist_free(pending_consensus_signature_list);
     pending_consensus_signature_list = NULL;
   }