From: Richard Purdie <richard.purdie@linuxfoundation.org>
Date: Wed, 8 Jun 2011 10:19:40 +0000 (+0100)
Subject: bitbake none/xmlrpc servers: Only send pickled events to the xmlrpc server
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b34d66225f4df23185870feb83626b1aab38bc11;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git

bitbake none/xmlrpc servers: Only send pickled events to the xmlrpc server

Only the xmlrpc server needs pickled events. Use the function names
to signify this requirement.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

diff --git a/bitbake/lib/bb/event.py b/bitbake/lib/bb/event.py
index cbe49fd699f..4ff530fcb4d 100644
--- a/bitbake/lib/bb/event.py
+++ b/bitbake/lib/bb/event.py
@@ -119,7 +119,10 @@ def fire_ui_handlers(event, d):
              # We use pickle here since it better handles object instances
              # which xmlrpc's marshaller does not. Events *must* be serializable
              # by pickle.
-            _ui_handlers[h].event.send((pickle.dumps(event)))
+             if hasattr(_ui_handlers[h].event, "sendpickle"):
+                _ui_handlers[h].event.sendpickle((pickle.dumps(event)))
+             else:
+                _ui_handlers[h].event.send(event)
         except:
             errors.append(h)
     for h in errors:
diff --git a/bitbake/lib/bb/server/none.py b/bitbake/lib/bb/server/none.py
index 6083631fe77..3be7b1daf64 100644
--- a/bitbake/lib/bb/server/none.py
+++ b/bitbake/lib/bb/server/none.py
@@ -28,7 +28,6 @@
 
 import time
 import bb
-import pickle
 import signal
 
 DEBUG = False
@@ -68,7 +67,7 @@ class BBUIEventQueue:
             self.parent = parent
         @staticmethod
         def send(event):
-            bb.server.none.eventQueue.append(pickle.loads(event))
+            bb.server.none.eventQueue.append(event)
         @staticmethod
         def quit():
             return
diff --git a/bitbake/lib/bb/ui/uievent.py b/bitbake/lib/bb/ui/uievent.py
index 2fef4e46598..0e738174e76 100644
--- a/bitbake/lib/bb/ui/uievent.py
+++ b/bitbake/lib/bb/ui/uievent.py
@@ -76,7 +76,7 @@ class BBUIEventQueue:
         self.host, self.port = server.socket.getsockname()
 
         server.register_function( self.system_quit, "event.quit" )
-        server.register_function( self.send_event, "event.send" )
+        server.register_function( self.send_event, "event.sendpickle" )
         server.socket.settimeout(1)
 
         self.EventHandle = self.BBServer.registerEventHandler(self.host, self.port)