From: Neal Norwitz Date: Sun, 7 Oct 2007 19:26:50 +0000 (+0000) Subject: At least one of the buildbots was complaining about newview being used X-Git-Tag: v3.0a2~357 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b35f128711e3dc618d92ab75eda3ba217904935e;p=thirdparty%2FPython%2Fcpython.git At least one of the buildbots was complaining about newview being used without being initialized. Also make the code conform to the comment and return the new object. This code needs a test! --- diff --git a/Objects/memoryobject.c b/Objects/memoryobject.c index d06d7e505f5c..754cbc1fbd67 100644 --- a/Objects/memoryobject.c +++ b/Objects/memoryobject.c @@ -513,12 +513,11 @@ memory_subscript(PyMemoryViewObject *self, PyObject *key) else { /* Return a new memory-view object */ Py_buffer newview; - PyMemoryView_FromMemory(&newview); + memset(&newview, 0, sizeof(newview)); + return PyMemoryView_FromMemory(&newview); } } - - Py_INCREF(Py_NotImplemented); return Py_NotImplemented; }