From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Wed, 30 Jun 2021 14:25:53 +0000 (+0200)
Subject: dnsdist: Reduce the "non-hashed password" messages to the info level
X-Git-Tag: dnsdist-1.7.0-alpha1~12^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b37379c22400e27b59665128f17d3d72c562d06c;p=thirdparty%2Fpdns.git

dnsdist: Reduce the "non-hashed password" messages to the info level
---

diff --git a/pdns/dnsdist-lua.cc b/pdns/dnsdist-lua.cc
index bd646ab0ed..9130bb34a3 100644
--- a/pdns/dnsdist-lua.cc
+++ b/pdns/dnsdist-lua.cc
@@ -946,7 +946,7 @@ static void setupLuaConfig(LuaContext& luaCtx, bool client, bool configCheck)
           if (password) {
             auto holder = make_unique<CredentialsHolder>(std::string(*password), false);
             if (!holder->wasHashed() && holder->isHashingAvailable()) {
-              warnlog("Passing a plain-text password to 'webserver()' is deprecated, please use 'setWebserverConfig()' with a hashed password instead.");
+              infolog("Passing a plain-text password to 'webserver()' is deprecated, please use 'setWebserverConfig()' instead and consider generating a hashed password using 'hashPassword()'.");
             }
 
             setWebserverPassword(std::move(holder));
@@ -999,7 +999,7 @@ static void setupLuaConfig(LuaContext& luaCtx, bool client, bool configCheck)
         std::string password = boost::get<std::string>(vars->at("password"));
         auto holder = make_unique<CredentialsHolder>(std::move(password), hashPlaintextCredentials);
         if (!holder->wasHashed() && holder->isHashingAvailable()) {
-          warnlog("Passing a plain-text password via the 'password' parameter to 'setWebserverConfig()' is deprecated, please generate a hashed one using 'hashPassword()' instead.");
+          infolog("Passing a plain-text password via the 'password' parameter to 'setWebserverConfig()' is not advised, please consider generating a hashed one using 'hashPassword()' instead.");
         }
 
         setWebserverPassword(std::move(holder));
@@ -1009,7 +1009,7 @@ static void setupLuaConfig(LuaContext& luaCtx, bool client, bool configCheck)
         std::string apiKey = boost::get<std::string>(vars->at("apiKey"));
         auto holder = make_unique<CredentialsHolder>(std::move(apiKey), hashPlaintextCredentials);
         if (!holder->wasHashed() && holder->isHashingAvailable()) {
-          warnlog("Passing a plain-text API key via the 'apiKey' parameter to 'setWebserverConfig()' is deprecated, please generate a hashed one using 'hashPassword()' instead.");
+          infolog("Passing a plain-text API key via the 'apiKey' parameter to 'setWebserverConfig()' is not advised, please consider generating a hashed one using 'hashPassword()' instead.");
         }
 
         setWebserverAPIKey(std::move(holder));