From: Björn Jacke <bj@sernet.de>
Date: Sun, 25 Aug 2019 21:08:18 +0000 (+0200)
Subject: s3/wscript: avoid inefficient string concatenations
X-Git-Tag: talloc-2.3.1~716
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b3b6b700c47ba771baf632b3a165106c21c9ae04;p=thirdparty%2Fsamba.git

s3/wscript: avoid inefficient string concatenations

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
---

diff --git a/source3/wscript b/source3/wscript
index dc2bb45a48b..83e7aca737f 100644
--- a/source3/wscript
+++ b/source3/wscript
@@ -1907,11 +1907,9 @@ main() {
         conf.env[static_env] = []
         conf.env[shared_env] = []
         if p in static_list:
-            decl_list=""
+            decl_list = " ".join("extern NTSTATUS %s_init(TALLOC_CTX *mem_ctx); " % entry for entry in static_list[p])
             for entry in static_list[p]:
-                decl_list += "extern NTSTATUS %s_init(TALLOC_CTX *mem_ctx); " % entry
                 conf.env[static_env].append('%s' % entry)
-            decl_list = decl_list.rstrip()
             conf.DEFINE('static_decl_%s' % p, decl_list)
             conf.DEFINE('static_init_%s(mem_ctx)' % p, '{ %s_init((mem_ctx)); }' % '_init((mem_ctx));  '.join(static_list[p]))
         else: