From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Thu, 31 May 2018 18:34:16 +0000 (+0600)
Subject: Don't cast to int‽
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b3e65a70eaea1fc04a602d7686be166033dcf18b;p=thirdparty%2Ffreeradius-server.git

Don't cast to int‽

No idea what this was there
---

diff --git a/src/lib/util/dict.c b/src/lib/util/dict.c
index cfdc474bfeb..c8b70b0e023 100644
--- a/src/lib/util/dict.c
+++ b/src/lib/util/dict.c
@@ -5464,7 +5464,7 @@ ssize_t fr_dict_valid_name(char const *name, ssize_t len)
 	end = p + len;
 
 	do {
-		if (!fr_dict_attr_allowed_chars[(int)*p]) {
+		if (!fr_dict_attr_allowed_chars[(uint8_t)*p]) {
 			fr_strerror_printf("Invalid character '%pV' in attribute name \"%pV\"",
 					   fr_box_strvalue_len(p, 1), fr_box_strvalue_len(name, len));