From: David Laight Date: Mon, 2 Mar 2026 10:17:55 +0000 (+0000) Subject: selftests/nolibc: Return correct value when printf test fails X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b42f02da2bf99460a7b1c5c25008f2e4a65ea4e3;p=thirdparty%2Fkernel%2Flinux.git selftests/nolibc: Return correct value when printf test fails Correctly return 1 (the number of errors) when strcmp() fails rather than the return value from strncmp() which is the signed difference between the mismatching characters. Signed-off-by: David Laight Acked-by: Willy Tarreau Link: https://patch.msgid.link/20260302101815.3043-4-david.laight.linux@gmail.com Signed-off-by: Thomas Weißschuh --- diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c index 801b2ad188537..7588212df1248 100644 --- a/tools/testing/selftests/nolibc/nolibc-test.c +++ b/tools/testing/selftests/nolibc/nolibc-test.c @@ -1691,7 +1691,7 @@ static int expect_vfprintf(int llen, int c, const char *expected, const char *fm } llen += printf(" \"%s\" = \"%s\"", expected, buf); - ret = strncmp(expected, buf, c); + ret = strncmp(expected, buf, c) != 0; result(llen, ret ? FAIL : OK); return ret;