From: VMware, Inc <>
Date: Thu, 2 Aug 2012 05:20:57 +0000 (-0700)
Subject: VMCI: remove memset() before free()
X-Git-Tag: 2012.10.14-874563~99
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b4493cb178e42161e7daafd5f116aae7e914e27a;p=thirdparty%2Fopen-vm-tools.git

VMCI: remove memset() before free()

Strip out redundant calls to memset() before free().

Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
---

diff --git a/open-vm-tools/modules/linux/vmci/common/vmciQPair.c b/open-vm-tools/modules/linux/vmci/common/vmciQPair.c
index 7465e5d92..a3d612f9d 100644
--- a/open-vm-tools/modules/linux/vmci/common/vmciQPair.c
+++ b/open-vm-tools/modules/linux/vmci/common/vmciQPair.c
@@ -600,9 +600,6 @@ VMCIQPair_Detach(VMCIQPair **qpair) // IN/OUT
    if (!(oldQPair->guestEndpoint || (oldQPair->flags & VMCI_QPFLAG_LOCAL))) {
       VMCI_DestroyEvent(&oldQPair->event);
    }
-   memset(oldQPair, 0, sizeof *oldQPair);
-   oldQPair->handle = VMCI_INVALID_HANDLE;
-   oldQPair->peer = VMCI_INVALID_ID;
    VMCI_FreeKernelMem(oldQPair, sizeof *oldQPair);
    *qpair = NULL;