From: Jonas Jelonek Date: Thu, 16 Jul 2026 23:03:36 +0000 (+0000) Subject: realtek: pcs: rtl931x: drop RX channel resets during USXGMII config X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b489ab0d86fcdf72c66cd5dbec13735d8cdd86d5;p=thirdparty%2Fopenwrt.git realtek: pcs: rtl931x: drop RX channel resets during USXGMII config The mode configuration calls LEQ/DFE reset and RX reset before doing USXGMII configuration. Though the SDK does that similar, these calls are actually unneeded because essentially the same is executed later again in the attachment configuration. This is also the place where it rather belongs. Thus, drop those calls in mode configuration. Link: https://github.com/openwrt/openwrt/pull/24310 Signed-off-by: Jonas Jelonek --- diff --git a/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c b/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c index bf9abc505dd..2598360e815 100644 --- a/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c +++ b/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c @@ -3262,6 +3262,7 @@ static int rtpcs_931x_sds_activate(struct rtpcs_serdes *sds) return rtpcs_931x_sds_power(sds, true); } +__maybe_unused static void rtpcs_931x_sds_rx_reset(struct rtpcs_serdes *sds) { if (sds->type != RTPCS_SDS_TYPE_10G) @@ -3684,9 +3685,6 @@ static int rtpcs_931x_sds_config_hw_mode(struct rtpcs_serdes *sds, case RTPCS_SDS_MODE_USXGMII_5GSXGMII: case RTPCS_SDS_MODE_USXGMII_5GDXGMII: case RTPCS_SDS_MODE_USXGMII_2_5GSXGMII: - rtpcs_931x_sds_reset_leq_dfe(sds); - rtpcs_931x_sds_rx_reset(sds); - rtpcs_93xx_sds_usxgmii_config(sds, RTPCS_USXGMII_AN_OPC_STD, 0xa4, 0, 1, 0x1); break;