From: Karolin Seeger <kseeger@samba.org>
Date: Fri, 9 Jan 2009 15:52:12 +0000 (+0100)
Subject: s3/net: Display error message if user does not exist.
X-Git-Tag: samba-4.0.0alpha6~168
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b516a2abcadb4a58fe7058ddbb4e38f53a467426;p=thirdparty%2Fsamba.git

s3/net: Display error message if user does not exist.

net rpc rights grant: Verify if the username can be resolved to a SID and
display a proper error message if it does not. Otherwise users might think
setting privileges worked fine, but in fact it does not.

Karolin
---

diff --git a/source3/utils/net_rpc_rights.c b/source3/utils/net_rpc_rights.c
index 2bc5efe3cf6..ddcfff3685f 100644
--- a/source3/utils/net_rpc_rights.c
+++ b/source3/utils/net_rpc_rights.c
@@ -449,8 +449,11 @@ static NTSTATUS rpc_rights_grant_internal(struct net_context *c,
 	}
 
 	result = name_to_sid(pipe_hnd, mem_ctx, &sid, argv[0]);
+	if (NT_STATUS_EQUAL(result, NT_STATUS_NONE_MAPPED))
+		result = NT_STATUS_NO_SUCH_USER;
+
 	if (!NT_STATUS_IS_OK(result))
-		return result;
+		goto done;
 
 	result = rpccli_lsa_open_policy2(pipe_hnd, mem_ctx, true,
 				     SEC_RIGHTS_MAXIMUM_ALLOWED,