From: Volker Lendecke <vl@samba.org>
Date: Wed, 1 Nov 2023 13:22:09 +0000 (+0100)
Subject: tests: Allow to specify share names in smb2symlink tests
X-Git-Tag: talloc-2.4.2~871
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b5392b552ed6b995196a91118bad11239eee25f7;p=thirdparty%2Fsamba.git

tests: Allow to specify share names in smb2symlink tests

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/tests/smb2symlink.py b/python/samba/tests/smb2symlink.py
index f501a549ec6..81e75718f82 100644
--- a/python/samba/tests/smb2symlink.py
+++ b/python/samba/tests/smb2symlink.py
@@ -23,16 +23,17 @@ import samba.tests.libsmb
 
 class Smb2SymlinkTests(samba.tests.libsmb.LibsmbTests):
 
-    def connections(self):
-        share = samba.tests.env_get_var_value(
-            "SMB1_SHARE", allow_missing=True)
-        if not share:
-            share = "nosymlinks_smb1allow"
+    def connections(self, smb1share=None, smb2share=None):
+        if not smb1share:
+            smb1share = samba.tests.env_get_var_value(
+                "SMB1_SHARE", allow_missing=True)
+            if not smb1share:
+                smb1share = "nosymlinks_smb1allow"
 
         try:
             smb1 = libsmb.Conn(
                 self.server_ip,
-                share,
+                smb1share,
                 self.lp,
                 self.creds,
                 force_smb1=True)
@@ -41,13 +42,15 @@ class Smb2SymlinkTests(samba.tests.libsmb.LibsmbTests):
                 raise
         smb1.smb1_posix()
 
-        share = samba.tests.env_get_var_value(
-            "SMB2_SHARE", allow_missing=True)
-        if not share:
-            share = "nosymlinks"
+        if not smb2share:
+            smb2share = samba.tests.env_get_var_value(
+                "SMB2_SHARE", allow_missing=True)
+            if not smb2share:
+                smb2share = "nosymlinks"
+
         smb2 = libsmb.Conn(
             self.server_ip,
-            share,
+            smb2share,
             self.lp,
             self.creds)
         return (smb1, smb2)