From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Thu, 27 May 2021 03:39:19 +0000 (+1200)
Subject: s3:pylibsmb: improve return types (false => NULL)
X-Git-Tag: tevent-0.11.0~443
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b54a24049f23165b445e79a3124460eed3d71bde;p=thirdparty%2Fsamba.git

s3:pylibsmb: improve return types (false => NULL)

NULL, a.k.a. (void *)false;

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/libsmb/pylibsmb.c b/source3/libsmb/pylibsmb.c
index 38dc5ecb8df..b498d3a0f62 100644
--- a/source3/libsmb/pylibsmb.c
+++ b/source3/libsmb/pylibsmb.c
@@ -1757,7 +1757,7 @@ static PyObject *py_smb_get_sd(struct py_cli_state *self, PyObject *args)
 	req = cli_query_security_descriptor_send(
 		NULL, self->ev, self->cli, fnum, sinfo);
 	if (!py_tevent_req_wait_exc(self, req)) {
-		return false;
+		return NULL;
 	}
 	status = cli_query_security_descriptor_recv(req, NULL, &sd);
 	PyErr_NTSTATUS_NOT_OK_RAISE(status);
@@ -1790,7 +1790,7 @@ static PyObject *py_smb_set_sd(struct py_cli_state *self, PyObject *args)
 	req = cli_set_security_descriptor_send(
 		NULL, self->ev, self->cli, fnum, sinfo, sd);
 	if (!py_tevent_req_wait_exc(self, req)) {
-		return false;
+		return NULL;
 	}
 
 	status = cli_set_security_descriptor_recv(req);