From: Victor Julien <victor@inliniac.net>
Date: Mon, 20 Jan 2014 09:42:12 +0000 (+0100)
Subject: app-layer-ssl: code cleanup
X-Git-Tag: suricata-2.0rc1~188
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b57ac888f8ee7a87461c77c6d114fd80917c7079;p=thirdparty%2Fsuricata.git

app-layer-ssl: code cleanup

Don't alloc a void ptr and then cast in every operation. Instead,
alloc a SSLState ptr and only case to void on returning the ptr.
---

diff --git a/src/app-layer-ssl.c b/src/app-layer-ssl.c
index d00709cfa1..53672803cf 100644
--- a/src/app-layer-ssl.c
+++ b/src/app-layer-ssl.c
@@ -951,15 +951,15 @@ int SSLParseServerRecord(Flow *f, void *alstate, AppLayerParserState *pstate,
  */
 void *SSLStateAlloc(void)
 {
-    void *ssl_state = SCMalloc(sizeof(SSLState));
+    SSLState *ssl_state = SCMalloc(sizeof(SSLState));
     if (unlikely(ssl_state == NULL))
         return NULL;
     memset(ssl_state, 0, sizeof(SSLState));
-    ((SSLState*)ssl_state)->client_connp.cert_log_flag = 0;
-    ((SSLState*)ssl_state)->server_connp.cert_log_flag = 0;
-    TAILQ_INIT(&((SSLState*)ssl_state)->server_connp.certs);
+    ssl_state->client_connp.cert_log_flag = 0;
+    ssl_state->server_connp.cert_log_flag = 0;
+    TAILQ_INIT(&ssl_state->server_connp.certs);
 
-    return ssl_state;
+    return (void *)ssl_state;
 }
 
 /**