From: Alexey Izbyshev <izbyshev@ispras.ru>
Date: Sat, 25 Aug 2018 23:52:27 +0000 (+0300)
Subject: closes bpo-34504: Remove the useless NULL check in PySequence_Check(). (GH-8935)
X-Git-Tag: v3.8.0a1~1154
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b57b4ac042b977e0b42a2f5ddb30ca7edffacfa9;p=thirdparty%2FPython%2Fcpython.git

closes bpo-34504: Remove the useless NULL check in PySequence_Check(). (GH-8935)

Reported by Svace static analyzer.
---

diff --git a/Objects/abstract.c b/Objects/abstract.c
index 8d3030a118ae..305910c3584c 100644
--- a/Objects/abstract.c
+++ b/Objects/abstract.c
@@ -1510,7 +1510,7 @@ PySequence_Check(PyObject *s)
 {
     if (PyDict_Check(s))
         return 0;
-    return s != NULL && s->ob_type->tp_as_sequence &&
+    return s->ob_type->tp_as_sequence &&
         s->ob_type->tp_as_sequence->sq_item != NULL;
 }