From: noxiouz Date: Tue, 7 Apr 2026 13:47:11 +0000 (+0100) Subject: networkd-wwan: handle link_get_by_name() errors in modem_simple_connect() X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b5a1ecb8fc837643abda78429f09f744aac7fe12;p=thirdparty%2Fsystemd.git networkd-wwan: handle link_get_by_name() errors in modem_simple_connect() modem_simple_connect() ignored the return value of link_get_by_name() and then checked link for NULL. Since the helper only sets the output pointer on success, that could read an indeterminate value. Check and log the return code directly with log_debug_errno(). Co-developed-by: Codex (GPT-5) --- diff --git a/src/network/networkd-wwan-bus.c b/src/network/networkd-wwan-bus.c index 5d981898752..434063ee6c1 100644 --- a/src/network/networkd-wwan-bus.c +++ b/src/network/networkd-wwan-bus.c @@ -604,9 +604,9 @@ static void modem_simple_connect(Modem *modem) { if (!modem->port_name) return; - (void) link_get_by_name(modem->manager, modem->port_name, &link); - if (!link) - return (void) log_debug("ModemManager: cannot find link for %s", modem->port_name); + r = link_get_by_name(modem->manager, modem->port_name, &link); + if (r < 0) + return (void) log_debug_errno(r, "ModemManager: cannot find link for %s: %m", modem->port_name); /* Check if .network file found at all */ if (!link->network)