From: Frantisek Sumsal <frantisek@sumsal.cz>
Date: Tue, 12 Jan 2021 21:13:33 +0000 (+0100)
Subject: ci: drop the `unbuffer` workaround
X-Git-Tag: v248-rc1~349^2~3
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b5a9b601c3301b208dba23e339dd5d2f0a32c9e4;p=thirdparty%2Fsystemd.git

ci: drop the `unbuffer` workaround

It actually didn't do anything, the issue was somewhere else.
---

diff --git a/.github/workflows/ubuntu-unit-tests.sh b/.github/workflows/ubuntu-unit-tests.sh
index 705b147b962..eccd048e28a 100755
--- a/.github/workflows/ubuntu-unit-tests.sh
+++ b/.github/workflows/ubuntu-unit-tests.sh
@@ -61,12 +61,7 @@ for phase in "${PHASES[@]}"; do
             export ASAN_OPTIONS=strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1
             # Never remove halt_on_error from UBSAN_OPTIONS. See https://github.com/systemd/systemd/commit/2614d83aa06592aedb.
             export UBSAN_OPTIONS=print_stacktrace=1:print_summary=1:halt_on_error=1
-            # There's some weird stuff going on in GH Actions, where the following
-            # `meson test` command hangs after test #252 unless it's executed under
-            # unbuffer or there's something else producing output. So far it happens
-            # _only_ with ASAn (not with UBSan), both with gcc and clang. I'll
-            # need to take a closer look later...
-            unbuffer meson test --timeout-multiplier=3 -C build --print-errorlogs
+            meson test --timeout-multiplier=3 -C build --print-errorlogs
             ;;
         CLEANUP)
             info "Cleanup phase"