From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Mon, 14 Jun 2021 06:43:43 +0000 (+0900)
Subject: network: drop misleading debugging logs about MTU
X-Git-Tag: v249-rc1~29
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b5d0fd1e7faa0bc331214cc7b50897df8728d9d9;p=thirdparty%2Fsystemd.git

network: drop misleading debugging logs about MTU

This fixes the following spurious logs on enumerating links:
```
wlan0: Saved original MTU 1500 (min: 256, max: 2304)
wlan0: MTU is changed: 0 → 1500 (min: 256, max: 2304)
```
---

diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c
index 911fb9b302c..27ad2c03a22 100644
--- a/src/network/networkd-link.c
+++ b/src/network/networkd-link.c
@@ -2038,6 +2038,8 @@ static int link_update_mtu(Link *link, sd_netlink_message *message) {
                 return 0;
         if (r < 0)
                 return log_link_debug_errno(link, r, "rtnl: failed to read MTU in RTM_NEWLINK message: %m");
+        if (mtu == 0)
+                return 0;
 
         r = sd_netlink_message_read_u32(message, IFLA_MIN_MTU, &min_mtu);
         if (r < 0 && r != -ENODATA)
@@ -2047,9 +2049,6 @@ static int link_update_mtu(Link *link, sd_netlink_message *message) {
         if (r < 0 && r != -ENODATA)
                 return log_link_debug_errno(link, r, "rtnl: failed to read maximum MTU in RTM_NEWLINK message: %m");
 
-        if (mtu == 0)
-                return 0;
-
         if (max_mtu == 0)
                 max_mtu = UINT32_MAX;
 
@@ -2065,8 +2064,9 @@ static int link_update_mtu(Link *link, sd_netlink_message *message) {
         if (link->mtu == mtu)
                 return 0;
 
-        log_link_debug(link, "MTU is changed: %"PRIu32" → %"PRIu32" (min: %"PRIu32", max: %"PRIu32")",
-                       link->mtu, mtu, link->min_mtu, link->max_mtu);
+        if (link->mtu != 0)
+                log_link_debug(link, "MTU is changed: %"PRIu32" → %"PRIu32" (min: %"PRIu32", max: %"PRIu32")",
+                               link->mtu, mtu, link->min_mtu, link->max_mtu);
 
         link->mtu = mtu;