From: Florian Weimer <fweimer@redhat.com>
Date: Thu, 6 Nov 2025 13:49:21 +0000 (+0100)
Subject: support: Exit on consistency check failure in resolv_response_add_name
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b64335ff111c071fde61aec1c1a8460afb3d16d4;p=thirdparty%2Fglibc.git

support: Exit on consistency check failure in resolv_response_add_name

Using TEST_VERIFY (crname_target != crname) instructs some analysis
tools that crname_target == crname might hold.  Under this assumption,
they report a use-after-free for crname_target->offset below, caused
by the previous free (crname).

Reviewed-by: Collin Funk <collin.funk1@gmail.com>
---

diff --git a/support/resolv_test.c b/support/resolv_test.c
index ab37d3d58c..29e59da958 100644
--- a/support/resolv_test.c
+++ b/support/resolv_test.c
@@ -326,7 +326,7 @@ resolv_response_add_name (struct resolv_response_builder *b,
               crname_target = *ptr;
             else
               crname_target = NULL;
-            TEST_VERIFY (crname_target != crname);
+            TEST_VERIFY_EXIT (crname_target != crname);
             /* Not added to the tree.  */
             free (crname);
           }