From: Nick Mathewson <nickm@torproject.org>
Date: Fri, 2 Dec 2011 20:37:24 +0000 (-0500)
Subject: Fix bug 4530; check return val of tor_addr_lookup correctly
X-Git-Tag: tor-0.2.3.9-alpha~19^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b7015603fa014c91056fa46cb012976a9e166cd3;p=thirdparty%2Ftor.git

Fix bug 4530; check return val of tor_addr_lookup correctly

Fix on 0.2.1.5-alpha; reported by troll_un
---

diff --git a/changes/bug4530 b/changes/bug4530
new file mode 100644
index 0000000000..7cd4726e57
--- /dev/null
+++ b/changes/bug4530
@@ -0,0 +1,6 @@
+  o Minor bugfixes:
+
+    - Correctly detect and handle transient lookup failures from
+      tor_addr_lookup. Fixes bug 4530; bugfix on 0.2.1.5-alpha.
+      Reported by "troll_un".
+
diff --git a/src/common/address.c b/src/common/address.c
index 46ccb1fe4a..17bdea9238 100644
--- a/src/common/address.c
+++ b/src/common/address.c
@@ -1034,7 +1034,7 @@ tor_addr_port_parse(const char *s, tor_addr_t *addr_out, uint16_t *port_out)
       ++port;
   }
 
-  if (tor_addr_lookup(tmp, AF_UNSPEC, &addr) < 0)
+  if (tor_addr_lookup(tmp, AF_UNSPEC, &addr) != 0)
     goto err;
   tor_free(tmp);