From: Pablo Sabater <pabloosabaterr@gmail.com>
Date: Fri, 24 Jul 2026 10:54:16 +0000 (+0200)
Subject: fetch-pack: use unsigned int for hash_algo variable
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b72559caa4ca3733b7694fa27364c4a9ac364159;p=thirdparty%2Fgit.git

fetch-pack: use unsigned int for hash_algo variable

hash_algo_by_name() returns unsigned int, but it is stored in
hash_algo variable as int. This goes unnoticed because of:

	DISABLE_SIGN_COMPARE_WARNINGS

On 'fetch-pack.c'

On a subsequent commit this function will be moved to 'connect.c' that
would notice this.

Change hash_algo variable type to match its return type, also make it
const because they are never modified.

Signed-off-by: Pablo Sabater <pabloosabaterr@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/fetch-pack.c b/fetch-pack.c
index 65ebfec09f..f1e64160fc 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -1397,7 +1397,7 @@ static void write_fetch_command_and_capabilities(struct strbuf *req_buf,
 	}
 
 	if (server_feature_v2("object-format", &hash_name)) {
-		int hash_algo = hash_algo_by_name(hash_name);
+		const unsigned int hash_algo = hash_algo_by_name(hash_name);
 		if (hash_algo_by_ptr(the_hash_algo) != hash_algo)
 			die(_("mismatched algorithms: client %s; server %s"),
 			    the_hash_algo->name, hash_name);