From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Mon, 8 May 2023 23:49:45 +0000 (-0700)
Subject: [3.11] GH-104308: socket.getnameinfo should release the GIL (GH-104307) (#104313)
X-Git-Tag: v3.11.4~98
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b7622e7a054497c9e9a17ee8c2b0bee33c098d5d;p=thirdparty%2FPython%2Fcpython.git

[3.11] GH-104308: socket.getnameinfo should release the GIL (GH-104307) (#104313)

GH-104308: socket.getnameinfo should release the GIL (GH-104307)

* socket.getnameinfo should release the GIL

* 📜🤖 Added by blurb_it.

---------

(cherry picked from commit faf196213e60d8a90773e9e5680d3252bd294643)

Co-authored-by: Nathaniel J. Smith <njs@pobox.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
---

diff --git a/Misc/NEWS.d/next/Library/2023-05-08-20-57-17.gh-issue-104307.DSB93G.rst b/Misc/NEWS.d/next/Library/2023-05-08-20-57-17.gh-issue-104307.DSB93G.rst
new file mode 100644
index 000000000000..03775845450c
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2023-05-08-20-57-17.gh-issue-104307.DSB93G.rst
@@ -0,0 +1 @@
+:func:`socket.getnameinfo` now releases the GIL while contacting the DNS server
diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
index 0e319a4cfd38..47539d354b49 100644
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@@ -6737,8 +6737,10 @@ socket_getnameinfo(PyObject *self, PyObject *args)
         }
 #endif
     }
+    Py_BEGIN_ALLOW_THREADS
     error = getnameinfo(res->ai_addr, (socklen_t) res->ai_addrlen,
                     hbuf, sizeof(hbuf), pbuf, sizeof(pbuf), flags);
+    Py_END_ALLOW_THREADS
     if (error) {
         set_gaierror(error);
         goto fail;