From: Simon McVittie <smcv@debian.org>
Date: Thu, 21 Jul 2016 09:55:06 +0000 (+0100)
Subject: _dbus_change_to_daemon_user (audit code path): set DBusError correctly
X-Git-Tag: dbus-1.11.4~10
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b7d280f623b716eb437f9742d5ff0b7229dfeacf;p=thirdparty%2Fdbus.git

_dbus_change_to_daemon_user (audit code path): set DBusError correctly

The other error cases here all set the error instead of just warning.

Signed-off-by: Simon McVittie <smcv@debian.org>
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=97009
---

diff --git a/bus/audit.c b/bus/audit.c
index 7705e4250..91f2c5cf6 100644
--- a/bus/audit.c
+++ b/bus/audit.c
@@ -166,8 +166,9 @@ _dbus_change_to_daemon_user  (const char    *user,
                               _dbus_strerror (errno));
               break;
             case -5:
-              _dbus_warn ("Failed to drop supplementary groups: %s\n",
-                          _dbus_strerror (errno));
+              dbus_set_error (error, _dbus_error_from_errno (errno),
+                              "Failed to drop supplementary groups: %s",
+                              _dbus_strerror (errno));
               break;
             case -6:
               dbus_set_error (error, _dbus_error_from_errno (errno),