From: John Thacker <johnthacker@gmail.com>
Date: Tue, 25 Jun 2024 22:31:39 +0000 (-0400)
Subject: pidl:Wireshark Fix array of pointers NULL termination
X-Git-Tag: tdb-1.4.11~200
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b8d902df0379f5a230743ddf63f40bbe78d915ae;p=thirdparty%2Fsamba.git

pidl:Wireshark Fix array of pointers NULL termination

Picked from Wireshark's PIDL fork:

    commit c07fd447c362099b04eedb445e8fa469643403f7
    Author: Binh Trinh <beango@gmail.com>
    Date:   Fri Jun 17 21:46:11 2016 -0400

        DCE/RPC: fix array of pointers with NULL

        Change-Id: Ie89f8fd4ec744d427d41866206d5a6784c5b224f
        Reviewed-on: https://code.wireshark.org/review/16004
        Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
        Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
        Reviewed-by: Michael Mann <mmann78@netscape.net>

Signed-off-by: John Thacker <johnthacker@gmail.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/pidl/lib/Parse/Pidl/Wireshark/NDR.pm b/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
index d4cbdb129d4..65ebcac555d 100644
--- a/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
+++ b/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
@@ -230,6 +230,7 @@ sub Bitmap($$$$)
 			$total_ev += hex($ev);
 			$self->pidl_code("&$hf_bitname,");
 		}
+		$self->pidl_code("NULL");
 		$self->deindent;
 		$self->pidl_code("};");
 	}