From: Michael Felt Date: Thu, 14 Feb 2019 18:22:35 +0000 (+0100) Subject: bpo-35633: test_lockf() fails with "PermissionError: [Errno 13] Permission denied... X-Git-Tag: v3.8.0a2~75 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b94d4bed67c60834b1a5a0936b8c13934cf3b872;p=thirdparty%2FPython%2Fcpython.git bpo-35633: test_lockf() fails with "PermissionError: [Errno 13] Permission denied" on AIX (GH-11424) [bpo-35633](https://bugs.python.org/issue35633): Fix a test regression introduced with [bpo-35189](https://bugs.python.org/issue35189) (PEP 475: fnctl functions are not retried if interrupted (EINTR)). Not only a blocking IO error needs to be ignored - permission errors also need to be ignored. p.s. - iirc as a "test" only correction a NEWS item is not required. If this is not correct - just mention, and I'll add a NEWS blurb. https://bugs.python.org/issue35633 --- diff --git a/Lib/test/eintrdata/eintr_tester.py b/Lib/test/eintrdata/eintr_tester.py index 25c169bde500..5f956b548fc4 100644 --- a/Lib/test/eintrdata/eintr_tester.py +++ b/Lib/test/eintrdata/eintr_tester.py @@ -12,6 +12,7 @@ import contextlib import faulthandler import fcntl import os +import platform import select import signal import socket @@ -518,6 +519,9 @@ class FNTLEINTRTest(EINTRBaseTest): self.stop_alarm() proc.wait() + # Issue 35633: See https://bugs.python.org/issue35633#msg333662 + # skip test rather than accept PermissionError from all platforms + @unittest.skipIf(platform.system() == "AIX", "AIX returns PermissionError") def test_lockf(self): self._lock(fcntl.lockf, "lockf")