From: Martti Rannanjärvi <martti.rannanjarvi@open-xchange.com>
Date: Wed, 19 Oct 2022 06:26:55 +0000 (+0300)
Subject: lib-storage: mail-storage-list-index-rebuild - Don't use continue inside T_BEGIN... 
X-Git-Tag: 2.4.0~3537
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b94fbef1a6a1a026d839ab6992bb40b93bfbe086;p=thirdparty%2Fdovecot%2Fcore.git

lib-storage: mail-storage-list-index-rebuild - Don't use continue inside T_BEGIN..T_END

Coverity doesn't like using continue there.
---

diff --git a/src/lib-storage/list/mail-storage-list-index-rebuild.c b/src/lib-storage/list/mail-storage-list-index-rebuild.c
index e17a3390a2..20873929e5 100644
--- a/src/lib-storage/list/mail-storage-list-index-rebuild.c
+++ b/src/lib-storage/list/mail-storage-list-index-rebuild.c
@@ -173,16 +173,18 @@ mail_storage_list_index_fill_storage_mailboxes(struct mail_storage_list_index_re
 				       ctx->storage->event, path,
 				       FS_ITER_FLAG_DIRS | FS_ITER_FLAG_NOCACHE);
 	while ((fname = fs_iter_next(iter)) != NULL) T_BEGIN {
-		if (guid_128_from_string(fname, guid) < 0)
-			continue;
-		box = p_new(ctx->pool, struct mail_storage_list_index_rebuild_mailbox, 1);
-		guid_128_copy(box->guid, guid);
-		e_debug(ctx->storage->event, "Found GUID '%s' from storage %s",
-			guid_128_to_string(guid), path);
-		char *hk = p_strdup_printf(ctx->pool, "%s%s", list->ns->prefix,
-					   guid_128_to_string(guid));
-		box->list = list;
-		hash_table_update(ctx->mailboxes, hk, box);
+		if (guid_128_from_string(fname, guid) == 0) {
+			box = p_new(ctx->pool, struct mail_storage_list_index_rebuild_mailbox, 1);
+			guid_128_copy(box->guid, guid);
+			e_debug(ctx->storage->event,
+				"Found GUID '%s' from storage %s",
+				guid_128_to_string(guid), path);
+			char *hk = p_strdup_printf(ctx->pool, "%s%s",
+						   list->ns->prefix,
+						   guid_128_to_string(guid));
+			box->list = list;
+			hash_table_update(ctx->mailboxes, hk, box);
+		}
 	} T_END;
 
 	if (fs_iter_deinit(&iter, &error) < 0) {