From: Shashank Parekh Date: Fri, 21 Jun 2019 03:02:22 +0000 (+0530) Subject: Remove redundant if check from optional argument function in argparse. (GH-8766) X-Git-Tag: v3.9.0a1~1209 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b9600b0fbd71908f9fb3dd1bf78ebba6c4a16115;p=thirdparty%2FPython%2Fcpython.git Remove redundant if check from optional argument function in argparse. (GH-8766) --- diff --git a/Lib/argparse.py b/Lib/argparse.py index 9a67b41ae00e..4f3aea928bf6 100644 --- a/Lib/argparse.py +++ b/Lib/argparse.py @@ -1479,10 +1479,8 @@ class _ActionsContainer(object): # strings starting with two prefix characters are long options option_strings.append(option_string) - if option_string[0] in self.prefix_chars: - if len(option_string) > 1: - if option_string[1] in self.prefix_chars: - long_option_strings.append(option_string) + if len(option_string) > 1 and option_string[1] in self.prefix_chars: + long_option_strings.append(option_string) # infer destination, '--foo-bar' -> 'foo_bar' and '-x' -> 'x' dest = kwargs.pop('dest', None)