From: Greg Kroah-Hartman Date: Wed, 26 Mar 2025 15:42:32 +0000 (-0400) Subject: drop arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch from... X-Git-Tag: v6.1.132~4 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b97f5543abf62332d52e371efe320defa662cac4;p=thirdparty%2Fkernel%2Fstable-queue.git drop arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch from everywhere --- diff --git a/queue-5.10/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch b/queue-5.10/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch deleted file mode 100644 index 05f8e1c12c..0000000000 --- a/queue-5.10/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch +++ /dev/null @@ -1,85 +0,0 @@ -From ffcef3df680c437ca33ff434be18ec24d72907c2 Mon Sep 17 00:00:00 2001 -From: Dragan Simic -Date: Sun, 2 Mar 2025 19:48:04 +0100 -Subject: arm64: dts: rockchip: Add missing PCIe supplies to RockPro64 board dtsi - -From: Dragan Simic - -commit ffcef3df680c437ca33ff434be18ec24d72907c2 upstream. - -Add missing "vpcie0v9-supply" and "vpcie1v8-supply" properties to the "pcie0" -node in the Pine64 RockPro64 board dtsi file. This eliminates the following -warnings from the kernel log: - - rockchip-pcie f8000000.pcie: supply vpcie1v8 not found, using dummy regulator - rockchip-pcie f8000000.pcie: supply vpcie0v9 not found, using dummy regulator - -These additions improve the accuracy of hardware description of the RockPro64 -and, in theory, they should result in no functional changes to the way board -works after the changes, because the "vcca_0v9" and "vcca_1v8" regulators are -always enabled. [1][2] However, extended reliability testing, performed by -Chris, [3] has proven that the age-old issues with some PCI Express cards, -when used with a Pine64 RockPro64, are also resolved. - -Those issues were already mentioned in the commit 43853e843aa6 (arm64: dts: -rockchip: Remove unsupported node from the Pinebook Pro dts, 2024-04-01), -together with a brief description of the out-of-tree enumeration delay patch -that reportedly resolves those issues. In a nutshell, booting a RockPro64 -with some PCI Express cards attached to it caused a kernel oops. [4] - -Symptomatically enough, to the commit author's best knowledge, only the Pine64 -RockPro64, out of all RK3399-based boards and devices supported upstream, has -been reported to suffer from those PCI Express issues, and only the RockPro64 -had some of the PCI Express supplies missing in its DT. Thus, perhaps some -weird timing issues exist that caused the "vcca_1v8" always-on regulator, -which is part of the RK808 PMIC, to actually not be enabled before the PCI -Express is initialized and enumerated on the RockPro64, causing oopses with -some PCIe cards, and the aforementioned enumeration delay patch [4] probably -acted as just a workaround for the underlying timing issue. - -Admittedly, the Pine64 RockPro64 is a bit specific board by having a standard -PCI Express slot, allowing use of various standard cards, but pretty much -standard PCI Express cards have been attached to other RK3399 boards as well, -and the commit author is unaware ot such issues reported for them. - -It's quite hard to be sure that the PCI Express issues are fully resolved by -these additions to the DT, without some really extensive and time-consuming -testing. However, these additions to the DT can result in good things and -improvements anyway, making them perfectly safe from the standpoint of being -unable to do any harm or cause some unforeseen regressions. - -These changes apply to the both supported hardware revisions of the Pine64 -RockPro64, i.e. to the production-run revisions 2.0 and 2.1. [1][2] - -[1] https://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf -[2] https://files.pine64.org/doc/rockpro64/rockpro64_v20-SCH.pdf -[3] https://z9.de/hedgedoc/s/nF4d5G7rg#reboot-tests-for-PCIe-improvements -[4] https://lore.kernel.org/lkml/20230509153912.515218-1-vincenzopalazzodev@gmail.com/T/#u - -Fixes: bba821f5479e ("arm64: dts: rockchip: add PCIe nodes on rk3399-rockpro64") -Cc: stable@vger.kernel.org -Cc: Vincenzo Palazzo -Cc: Peter Geis -Cc: Bjorn Helgaas -Reported-by: Diederik de Haas -Tested-by: Chris Vogel -Signed-off-by: Dragan Simic -Tested-by: Diederik de Haas -Link: https://lore.kernel.org/r/b39cfd7490d8194f053bf3971f13a43472d1769e.1740941097.git.dsimic@manjaro.org -Signed-off-by: Heiko Stuebner -Signed-off-by: Greg Kroah-Hartman ---- - arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 2 ++ - 1 file changed, 2 insertions(+) - ---- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi -+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi -@@ -546,6 +546,8 @@ - num-lanes = <4>; - pinctrl-names = "default"; - pinctrl-0 = <&pcie_perst>; -+ vpcie0v9-supply = <&vcca_0v9>; -+ vpcie1v8-supply = <&vcca_1v8>; - vpcie12v-supply = <&vcc12v_dcin>; - vpcie3v3-supply = <&vcc3v3_pcie>; - status = "okay"; diff --git a/queue-5.10/series b/queue-5.10/series index 0c49e25e5f..67a22ef445 100644 --- a/queue-5.10/series +++ b/queue-5.10/series @@ -82,7 +82,6 @@ net-neighbor-add-missing-policy-for-ndtpa_queue_lenb.patch i2c-omap-fix-irq-storms.patch drm-v3d-don-t-run-jobs-that-have-errors-flagged-in-its-fence.patch regulator-check-that-dummy-regulator-has-been-probed-before-using-it.patch -arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch mmc-atmel-mci-add-missing-clk_disable_unprepare.patch proc-fix-uaf-in-proc_get_inode.patch arm-shmobile-smp-enforce-shmobile_smp_-alignment.patch diff --git a/queue-5.15/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch b/queue-5.15/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch deleted file mode 100644 index 05e13f2f52..0000000000 --- a/queue-5.15/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch +++ /dev/null @@ -1,85 +0,0 @@ -From ffcef3df680c437ca33ff434be18ec24d72907c2 Mon Sep 17 00:00:00 2001 -From: Dragan Simic -Date: Sun, 2 Mar 2025 19:48:04 +0100 -Subject: arm64: dts: rockchip: Add missing PCIe supplies to RockPro64 board dtsi - -From: Dragan Simic - -commit ffcef3df680c437ca33ff434be18ec24d72907c2 upstream. - -Add missing "vpcie0v9-supply" and "vpcie1v8-supply" properties to the "pcie0" -node in the Pine64 RockPro64 board dtsi file. This eliminates the following -warnings from the kernel log: - - rockchip-pcie f8000000.pcie: supply vpcie1v8 not found, using dummy regulator - rockchip-pcie f8000000.pcie: supply vpcie0v9 not found, using dummy regulator - -These additions improve the accuracy of hardware description of the RockPro64 -and, in theory, they should result in no functional changes to the way board -works after the changes, because the "vcca_0v9" and "vcca_1v8" regulators are -always enabled. [1][2] However, extended reliability testing, performed by -Chris, [3] has proven that the age-old issues with some PCI Express cards, -when used with a Pine64 RockPro64, are also resolved. - -Those issues were already mentioned in the commit 43853e843aa6 (arm64: dts: -rockchip: Remove unsupported node from the Pinebook Pro dts, 2024-04-01), -together with a brief description of the out-of-tree enumeration delay patch -that reportedly resolves those issues. In a nutshell, booting a RockPro64 -with some PCI Express cards attached to it caused a kernel oops. [4] - -Symptomatically enough, to the commit author's best knowledge, only the Pine64 -RockPro64, out of all RK3399-based boards and devices supported upstream, has -been reported to suffer from those PCI Express issues, and only the RockPro64 -had some of the PCI Express supplies missing in its DT. Thus, perhaps some -weird timing issues exist that caused the "vcca_1v8" always-on regulator, -which is part of the RK808 PMIC, to actually not be enabled before the PCI -Express is initialized and enumerated on the RockPro64, causing oopses with -some PCIe cards, and the aforementioned enumeration delay patch [4] probably -acted as just a workaround for the underlying timing issue. - -Admittedly, the Pine64 RockPro64 is a bit specific board by having a standard -PCI Express slot, allowing use of various standard cards, but pretty much -standard PCI Express cards have been attached to other RK3399 boards as well, -and the commit author is unaware ot such issues reported for them. - -It's quite hard to be sure that the PCI Express issues are fully resolved by -these additions to the DT, without some really extensive and time-consuming -testing. However, these additions to the DT can result in good things and -improvements anyway, making them perfectly safe from the standpoint of being -unable to do any harm or cause some unforeseen regressions. - -These changes apply to the both supported hardware revisions of the Pine64 -RockPro64, i.e. to the production-run revisions 2.0 and 2.1. [1][2] - -[1] https://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf -[2] https://files.pine64.org/doc/rockpro64/rockpro64_v20-SCH.pdf -[3] https://z9.de/hedgedoc/s/nF4d5G7rg#reboot-tests-for-PCIe-improvements -[4] https://lore.kernel.org/lkml/20230509153912.515218-1-vincenzopalazzodev@gmail.com/T/#u - -Fixes: bba821f5479e ("arm64: dts: rockchip: add PCIe nodes on rk3399-rockpro64") -Cc: stable@vger.kernel.org -Cc: Vincenzo Palazzo -Cc: Peter Geis -Cc: Bjorn Helgaas -Reported-by: Diederik de Haas -Tested-by: Chris Vogel -Signed-off-by: Dragan Simic -Tested-by: Diederik de Haas -Link: https://lore.kernel.org/r/b39cfd7490d8194f053bf3971f13a43472d1769e.1740941097.git.dsimic@manjaro.org -Signed-off-by: Heiko Stuebner -Signed-off-by: Greg Kroah-Hartman ---- - arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 2 ++ - 1 file changed, 2 insertions(+) - ---- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi -+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi -@@ -576,6 +576,8 @@ - num-lanes = <4>; - pinctrl-names = "default"; - pinctrl-0 = <&pcie_perst>; -+ vpcie0v9-supply = <&vcca_0v9>; -+ vpcie1v8-supply = <&vcca_1v8>; - vpcie12v-supply = <&vcc12v_dcin>; - vpcie3v3-supply = <&vcc3v3_pcie>; - status = "okay"; diff --git a/queue-5.15/series b/queue-5.15/series index 5474a04738..e30f4a9c6f 100644 --- a/queue-5.15/series +++ b/queue-5.15/series @@ -96,7 +96,6 @@ revert-gre-fix-ipv6-link-local-address-generation.patch i2c-omap-fix-irq-storms.patch drm-v3d-don-t-run-jobs-that-have-errors-flagged-in-its-fence.patch regulator-check-that-dummy-regulator-has-been-probed-before-using-it.patch -arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch mmc-atmel-mci-add-missing-clk_disable_unprepare.patch proc-fix-uaf-in-proc_get_inode.patch arm-shmobile-smp-enforce-shmobile_smp_-alignment.patch diff --git a/queue-6.1/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch b/queue-6.1/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch deleted file mode 100644 index 0d0154e0cb..0000000000 --- a/queue-6.1/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch +++ /dev/null @@ -1,85 +0,0 @@ -From ffcef3df680c437ca33ff434be18ec24d72907c2 Mon Sep 17 00:00:00 2001 -From: Dragan Simic -Date: Sun, 2 Mar 2025 19:48:04 +0100 -Subject: arm64: dts: rockchip: Add missing PCIe supplies to RockPro64 board dtsi - -From: Dragan Simic - -commit ffcef3df680c437ca33ff434be18ec24d72907c2 upstream. - -Add missing "vpcie0v9-supply" and "vpcie1v8-supply" properties to the "pcie0" -node in the Pine64 RockPro64 board dtsi file. This eliminates the following -warnings from the kernel log: - - rockchip-pcie f8000000.pcie: supply vpcie1v8 not found, using dummy regulator - rockchip-pcie f8000000.pcie: supply vpcie0v9 not found, using dummy regulator - -These additions improve the accuracy of hardware description of the RockPro64 -and, in theory, they should result in no functional changes to the way board -works after the changes, because the "vcca_0v9" and "vcca_1v8" regulators are -always enabled. [1][2] However, extended reliability testing, performed by -Chris, [3] has proven that the age-old issues with some PCI Express cards, -when used with a Pine64 RockPro64, are also resolved. - -Those issues were already mentioned in the commit 43853e843aa6 (arm64: dts: -rockchip: Remove unsupported node from the Pinebook Pro dts, 2024-04-01), -together with a brief description of the out-of-tree enumeration delay patch -that reportedly resolves those issues. In a nutshell, booting a RockPro64 -with some PCI Express cards attached to it caused a kernel oops. [4] - -Symptomatically enough, to the commit author's best knowledge, only the Pine64 -RockPro64, out of all RK3399-based boards and devices supported upstream, has -been reported to suffer from those PCI Express issues, and only the RockPro64 -had some of the PCI Express supplies missing in its DT. Thus, perhaps some -weird timing issues exist that caused the "vcca_1v8" always-on regulator, -which is part of the RK808 PMIC, to actually not be enabled before the PCI -Express is initialized and enumerated on the RockPro64, causing oopses with -some PCIe cards, and the aforementioned enumeration delay patch [4] probably -acted as just a workaround for the underlying timing issue. - -Admittedly, the Pine64 RockPro64 is a bit specific board by having a standard -PCI Express slot, allowing use of various standard cards, but pretty much -standard PCI Express cards have been attached to other RK3399 boards as well, -and the commit author is unaware ot such issues reported for them. - -It's quite hard to be sure that the PCI Express issues are fully resolved by -these additions to the DT, without some really extensive and time-consuming -testing. However, these additions to the DT can result in good things and -improvements anyway, making them perfectly safe from the standpoint of being -unable to do any harm or cause some unforeseen regressions. - -These changes apply to the both supported hardware revisions of the Pine64 -RockPro64, i.e. to the production-run revisions 2.0 and 2.1. [1][2] - -[1] https://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf -[2] https://files.pine64.org/doc/rockpro64/rockpro64_v20-SCH.pdf -[3] https://z9.de/hedgedoc/s/nF4d5G7rg#reboot-tests-for-PCIe-improvements -[4] https://lore.kernel.org/lkml/20230509153912.515218-1-vincenzopalazzodev@gmail.com/T/#u - -Fixes: bba821f5479e ("arm64: dts: rockchip: add PCIe nodes on rk3399-rockpro64") -Cc: stable@vger.kernel.org -Cc: Vincenzo Palazzo -Cc: Peter Geis -Cc: Bjorn Helgaas -Reported-by: Diederik de Haas -Tested-by: Chris Vogel -Signed-off-by: Dragan Simic -Tested-by: Diederik de Haas -Link: https://lore.kernel.org/r/b39cfd7490d8194f053bf3971f13a43472d1769e.1740941097.git.dsimic@manjaro.org -Signed-off-by: Heiko Stuebner -Signed-off-by: Greg Kroah-Hartman ---- - arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 2 ++ - 1 file changed, 2 insertions(+) - ---- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi -+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi -@@ -667,6 +667,8 @@ - num-lanes = <4>; - pinctrl-names = "default"; - pinctrl-0 = <&pcie_perst>; -+ vpcie0v9-supply = <&vcca_0v9>; -+ vpcie1v8-supply = <&vcca_1v8>; - vpcie12v-supply = <&vcc12v_dcin>; - vpcie3v3-supply = <&vcc3v3_pcie>; - status = "okay"; diff --git a/queue-6.1/series b/queue-6.1/series index 5598e1b414..ee88890d69 100644 --- a/queue-6.1/series +++ b/queue-6.1/series @@ -172,7 +172,6 @@ can-flexcan-disable-transceiver-during-system-pm.patch drm-v3d-don-t-run-jobs-that-have-errors-flagged-in-its-fence.patch regulator-check-that-dummy-regulator-has-been-probed-before-using-it.patch arm64-dts-freescale-imx8mm-verdin-dahlia-add-microphone-jack-to-sound-card.patch -arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch mmc-sdhci-brcmstb-add-cqhci-suspend-resume-to-pm-ops.patch mmc-atmel-mci-add-missing-clk_disable_unprepare.patch proc-fix-uaf-in-proc_get_inode.patch diff --git a/queue-6.12/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch b/queue-6.12/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch deleted file mode 100644 index aa54571789..0000000000 --- a/queue-6.12/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch +++ /dev/null @@ -1,85 +0,0 @@ -From ffcef3df680c437ca33ff434be18ec24d72907c2 Mon Sep 17 00:00:00 2001 -From: Dragan Simic -Date: Sun, 2 Mar 2025 19:48:04 +0100 -Subject: arm64: dts: rockchip: Add missing PCIe supplies to RockPro64 board dtsi - -From: Dragan Simic - -commit ffcef3df680c437ca33ff434be18ec24d72907c2 upstream. - -Add missing "vpcie0v9-supply" and "vpcie1v8-supply" properties to the "pcie0" -node in the Pine64 RockPro64 board dtsi file. This eliminates the following -warnings from the kernel log: - - rockchip-pcie f8000000.pcie: supply vpcie1v8 not found, using dummy regulator - rockchip-pcie f8000000.pcie: supply vpcie0v9 not found, using dummy regulator - -These additions improve the accuracy of hardware description of the RockPro64 -and, in theory, they should result in no functional changes to the way board -works after the changes, because the "vcca_0v9" and "vcca_1v8" regulators are -always enabled. [1][2] However, extended reliability testing, performed by -Chris, [3] has proven that the age-old issues with some PCI Express cards, -when used with a Pine64 RockPro64, are also resolved. - -Those issues were already mentioned in the commit 43853e843aa6 (arm64: dts: -rockchip: Remove unsupported node from the Pinebook Pro dts, 2024-04-01), -together with a brief description of the out-of-tree enumeration delay patch -that reportedly resolves those issues. In a nutshell, booting a RockPro64 -with some PCI Express cards attached to it caused a kernel oops. [4] - -Symptomatically enough, to the commit author's best knowledge, only the Pine64 -RockPro64, out of all RK3399-based boards and devices supported upstream, has -been reported to suffer from those PCI Express issues, and only the RockPro64 -had some of the PCI Express supplies missing in its DT. Thus, perhaps some -weird timing issues exist that caused the "vcca_1v8" always-on regulator, -which is part of the RK808 PMIC, to actually not be enabled before the PCI -Express is initialized and enumerated on the RockPro64, causing oopses with -some PCIe cards, and the aforementioned enumeration delay patch [4] probably -acted as just a workaround for the underlying timing issue. - -Admittedly, the Pine64 RockPro64 is a bit specific board by having a standard -PCI Express slot, allowing use of various standard cards, but pretty much -standard PCI Express cards have been attached to other RK3399 boards as well, -and the commit author is unaware ot such issues reported for them. - -It's quite hard to be sure that the PCI Express issues are fully resolved by -these additions to the DT, without some really extensive and time-consuming -testing. However, these additions to the DT can result in good things and -improvements anyway, making them perfectly safe from the standpoint of being -unable to do any harm or cause some unforeseen regressions. - -These changes apply to the both supported hardware revisions of the Pine64 -RockPro64, i.e. to the production-run revisions 2.0 and 2.1. [1][2] - -[1] https://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf -[2] https://files.pine64.org/doc/rockpro64/rockpro64_v20-SCH.pdf -[3] https://z9.de/hedgedoc/s/nF4d5G7rg#reboot-tests-for-PCIe-improvements -[4] https://lore.kernel.org/lkml/20230509153912.515218-1-vincenzopalazzodev@gmail.com/T/#u - -Fixes: bba821f5479e ("arm64: dts: rockchip: add PCIe nodes on rk3399-rockpro64") -Cc: stable@vger.kernel.org -Cc: Vincenzo Palazzo -Cc: Peter Geis -Cc: Bjorn Helgaas -Reported-by: Diederik de Haas -Tested-by: Chris Vogel -Signed-off-by: Dragan Simic -Tested-by: Diederik de Haas -Link: https://lore.kernel.org/r/b39cfd7490d8194f053bf3971f13a43472d1769e.1740941097.git.dsimic@manjaro.org -Signed-off-by: Heiko Stuebner -Signed-off-by: Greg Kroah-Hartman ---- - arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 2 ++ - 1 file changed, 2 insertions(+) - ---- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi -+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi -@@ -661,6 +661,8 @@ - num-lanes = <4>; - pinctrl-names = "default"; - pinctrl-0 = <&pcie_perst>; -+ vpcie0v9-supply = <&vcca_0v9>; -+ vpcie1v8-supply = <&vcca_1v8>; - vpcie12v-supply = <&vcc12v_dcin>; - vpcie3v3-supply = <&vcc3v3_pcie>; - status = "okay"; diff --git a/queue-6.12/series b/queue-6.12/series index 85bae61694..c61e640bf3 100644 --- a/queue-6.12/series +++ b/queue-6.12/series @@ -68,7 +68,6 @@ arm64-dts-freescale-imx8mp-verdin-dahlia-add-microphone-jack-to-sound-card.patch arm64-dts-freescale-imx8mm-verdin-dahlia-add-microphone-jack-to-sound-card.patch arm64-dts-rockchip-fix-pinmux-of-uart0-for-px30-ringneck-on-haikou.patch arm64-dts-rockchip-fix-pinmux-of-uart5-for-px30-ringneck-on-haikou.patch -arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch mmc-sdhci-brcmstb-add-cqhci-suspend-resume-to-pm-ops.patch mmc-atmel-mci-add-missing-clk_disable_unprepare.patch selftests-mm-run_vmtests.sh-fix-half_ufd_size_mb-calculation.patch diff --git a/queue-6.13/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch b/queue-6.13/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch deleted file mode 100644 index d7394b5f40..0000000000 --- a/queue-6.13/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch +++ /dev/null @@ -1,85 +0,0 @@ -From ffcef3df680c437ca33ff434be18ec24d72907c2 Mon Sep 17 00:00:00 2001 -From: Dragan Simic -Date: Sun, 2 Mar 2025 19:48:04 +0100 -Subject: arm64: dts: rockchip: Add missing PCIe supplies to RockPro64 board dtsi - -From: Dragan Simic - -commit ffcef3df680c437ca33ff434be18ec24d72907c2 upstream. - -Add missing "vpcie0v9-supply" and "vpcie1v8-supply" properties to the "pcie0" -node in the Pine64 RockPro64 board dtsi file. This eliminates the following -warnings from the kernel log: - - rockchip-pcie f8000000.pcie: supply vpcie1v8 not found, using dummy regulator - rockchip-pcie f8000000.pcie: supply vpcie0v9 not found, using dummy regulator - -These additions improve the accuracy of hardware description of the RockPro64 -and, in theory, they should result in no functional changes to the way board -works after the changes, because the "vcca_0v9" and "vcca_1v8" regulators are -always enabled. [1][2] However, extended reliability testing, performed by -Chris, [3] has proven that the age-old issues with some PCI Express cards, -when used with a Pine64 RockPro64, are also resolved. - -Those issues were already mentioned in the commit 43853e843aa6 (arm64: dts: -rockchip: Remove unsupported node from the Pinebook Pro dts, 2024-04-01), -together with a brief description of the out-of-tree enumeration delay patch -that reportedly resolves those issues. In a nutshell, booting a RockPro64 -with some PCI Express cards attached to it caused a kernel oops. [4] - -Symptomatically enough, to the commit author's best knowledge, only the Pine64 -RockPro64, out of all RK3399-based boards and devices supported upstream, has -been reported to suffer from those PCI Express issues, and only the RockPro64 -had some of the PCI Express supplies missing in its DT. Thus, perhaps some -weird timing issues exist that caused the "vcca_1v8" always-on regulator, -which is part of the RK808 PMIC, to actually not be enabled before the PCI -Express is initialized and enumerated on the RockPro64, causing oopses with -some PCIe cards, and the aforementioned enumeration delay patch [4] probably -acted as just a workaround for the underlying timing issue. - -Admittedly, the Pine64 RockPro64 is a bit specific board by having a standard -PCI Express slot, allowing use of various standard cards, but pretty much -standard PCI Express cards have been attached to other RK3399 boards as well, -and the commit author is unaware ot such issues reported for them. - -It's quite hard to be sure that the PCI Express issues are fully resolved by -these additions to the DT, without some really extensive and time-consuming -testing. However, these additions to the DT can result in good things and -improvements anyway, making them perfectly safe from the standpoint of being -unable to do any harm or cause some unforeseen regressions. - -These changes apply to the both supported hardware revisions of the Pine64 -RockPro64, i.e. to the production-run revisions 2.0 and 2.1. [1][2] - -[1] https://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf -[2] https://files.pine64.org/doc/rockpro64/rockpro64_v20-SCH.pdf -[3] https://z9.de/hedgedoc/s/nF4d5G7rg#reboot-tests-for-PCIe-improvements -[4] https://lore.kernel.org/lkml/20230509153912.515218-1-vincenzopalazzodev@gmail.com/T/#u - -Fixes: bba821f5479e ("arm64: dts: rockchip: add PCIe nodes on rk3399-rockpro64") -Cc: stable@vger.kernel.org -Cc: Vincenzo Palazzo -Cc: Peter Geis -Cc: Bjorn Helgaas -Reported-by: Diederik de Haas -Tested-by: Chris Vogel -Signed-off-by: Dragan Simic -Tested-by: Diederik de Haas -Link: https://lore.kernel.org/r/b39cfd7490d8194f053bf3971f13a43472d1769e.1740941097.git.dsimic@manjaro.org -Signed-off-by: Heiko Stuebner -Signed-off-by: Greg Kroah-Hartman ---- - arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 2 ++ - 1 file changed, 2 insertions(+) - ---- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi -+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi -@@ -673,6 +673,8 @@ - num-lanes = <4>; - pinctrl-names = "default"; - pinctrl-0 = <&pcie_perst>; -+ vpcie0v9-supply = <&vcca_0v9>; -+ vpcie1v8-supply = <&vcca_1v8>; - vpcie12v-supply = <&vcc12v_dcin>; - vpcie3v3-supply = <&vcc3v3_pcie>; - status = "okay"; diff --git a/queue-6.13/series b/queue-6.13/series index 920b93b01d..1e8e10c2ce 100644 --- a/queue-6.13/series +++ b/queue-6.13/series @@ -72,7 +72,6 @@ arm64-dts-rockchip-fix-pinmux-of-uart0-for-px30-ringneck-on-haikou.patch arm64-dts-rockchip-fix-pinmux-of-uart5-for-px30-ringneck-on-haikou.patch arm64-dts-rockchip-fix-u2phy1_host-status-for-nanopi-r4s.patch arm64-dts-rockchip-add-avdd-hdmi-supplies-to-rockpro64-board-dtsi.patch -arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch mmc-sdhci-brcmstb-add-cqhci-suspend-resume-to-pm-ops.patch mmc-atmel-mci-add-missing-clk_disable_unprepare.patch selftests-mm-run_vmtests.sh-fix-half_ufd_size_mb-calculation.patch diff --git a/queue-6.6/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch b/queue-6.6/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch deleted file mode 100644 index aa54571789..0000000000 --- a/queue-6.6/arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch +++ /dev/null @@ -1,85 +0,0 @@ -From ffcef3df680c437ca33ff434be18ec24d72907c2 Mon Sep 17 00:00:00 2001 -From: Dragan Simic -Date: Sun, 2 Mar 2025 19:48:04 +0100 -Subject: arm64: dts: rockchip: Add missing PCIe supplies to RockPro64 board dtsi - -From: Dragan Simic - -commit ffcef3df680c437ca33ff434be18ec24d72907c2 upstream. - -Add missing "vpcie0v9-supply" and "vpcie1v8-supply" properties to the "pcie0" -node in the Pine64 RockPro64 board dtsi file. This eliminates the following -warnings from the kernel log: - - rockchip-pcie f8000000.pcie: supply vpcie1v8 not found, using dummy regulator - rockchip-pcie f8000000.pcie: supply vpcie0v9 not found, using dummy regulator - -These additions improve the accuracy of hardware description of the RockPro64 -and, in theory, they should result in no functional changes to the way board -works after the changes, because the "vcca_0v9" and "vcca_1v8" regulators are -always enabled. [1][2] However, extended reliability testing, performed by -Chris, [3] has proven that the age-old issues with some PCI Express cards, -when used with a Pine64 RockPro64, are also resolved. - -Those issues were already mentioned in the commit 43853e843aa6 (arm64: dts: -rockchip: Remove unsupported node from the Pinebook Pro dts, 2024-04-01), -together with a brief description of the out-of-tree enumeration delay patch -that reportedly resolves those issues. In a nutshell, booting a RockPro64 -with some PCI Express cards attached to it caused a kernel oops. [4] - -Symptomatically enough, to the commit author's best knowledge, only the Pine64 -RockPro64, out of all RK3399-based boards and devices supported upstream, has -been reported to suffer from those PCI Express issues, and only the RockPro64 -had some of the PCI Express supplies missing in its DT. Thus, perhaps some -weird timing issues exist that caused the "vcca_1v8" always-on regulator, -which is part of the RK808 PMIC, to actually not be enabled before the PCI -Express is initialized and enumerated on the RockPro64, causing oopses with -some PCIe cards, and the aforementioned enumeration delay patch [4] probably -acted as just a workaround for the underlying timing issue. - -Admittedly, the Pine64 RockPro64 is a bit specific board by having a standard -PCI Express slot, allowing use of various standard cards, but pretty much -standard PCI Express cards have been attached to other RK3399 boards as well, -and the commit author is unaware ot such issues reported for them. - -It's quite hard to be sure that the PCI Express issues are fully resolved by -these additions to the DT, without some really extensive and time-consuming -testing. However, these additions to the DT can result in good things and -improvements anyway, making them perfectly safe from the standpoint of being -unable to do any harm or cause some unforeseen regressions. - -These changes apply to the both supported hardware revisions of the Pine64 -RockPro64, i.e. to the production-run revisions 2.0 and 2.1. [1][2] - -[1] https://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf -[2] https://files.pine64.org/doc/rockpro64/rockpro64_v20-SCH.pdf -[3] https://z9.de/hedgedoc/s/nF4d5G7rg#reboot-tests-for-PCIe-improvements -[4] https://lore.kernel.org/lkml/20230509153912.515218-1-vincenzopalazzodev@gmail.com/T/#u - -Fixes: bba821f5479e ("arm64: dts: rockchip: add PCIe nodes on rk3399-rockpro64") -Cc: stable@vger.kernel.org -Cc: Vincenzo Palazzo -Cc: Peter Geis -Cc: Bjorn Helgaas -Reported-by: Diederik de Haas -Tested-by: Chris Vogel -Signed-off-by: Dragan Simic -Tested-by: Diederik de Haas -Link: https://lore.kernel.org/r/b39cfd7490d8194f053bf3971f13a43472d1769e.1740941097.git.dsimic@manjaro.org -Signed-off-by: Heiko Stuebner -Signed-off-by: Greg Kroah-Hartman ---- - arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 2 ++ - 1 file changed, 2 insertions(+) - ---- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi -+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi -@@ -661,6 +661,8 @@ - num-lanes = <4>; - pinctrl-names = "default"; - pinctrl-0 = <&pcie_perst>; -+ vpcie0v9-supply = <&vcca_0v9>; -+ vpcie1v8-supply = <&vcca_1v8>; - vpcie12v-supply = <&vcc12v_dcin>; - vpcie3v3-supply = <&vcc3v3_pcie>; - status = "okay"; diff --git a/queue-6.6/series b/queue-6.6/series index 654e20c5a4..bc34b456e2 100644 --- a/queue-6.6/series +++ b/queue-6.6/series @@ -39,7 +39,6 @@ accel-qaic-fix-integer-overflow-in-qaic_validate_req.patch arm64-dts-freescale-imx8mp-verdin-dahlia-add-microphone-jack-to-sound-card.patch arm64-dts-freescale-imx8mm-verdin-dahlia-add-microphone-jack-to-sound-card.patch arm64-dts-rockchip-fix-pinmux-of-uart0-for-px30-ringneck-on-haikou.patch -arm64-dts-rockchip-add-missing-pcie-supplies-to-rockpro64-board-dtsi.patch mmc-sdhci-brcmstb-add-cqhci-suspend-resume-to-pm-ops.patch mmc-atmel-mci-add-missing-clk_disable_unprepare.patch mm-fix-error-handling-in-__filemap_get_folio-with-fgp_nowait.patch