From: Volker Lendecke <vl@samba.org>
Date: Mon, 19 Aug 2024 07:10:03 +0000 (+0200)
Subject: libsmb: Remove a reference to cli_errno()
X-Git-Tag: tdb-1.4.13~1355
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=b9c018d17ecd10c9a860fbce5d8b2e391767c975;p=thirdparty%2Fsamba.git

libsmb: Remove a reference to cli_errno()

If I see it correctly, this case was already covered by checking the
return code of cli_trans() a few lines above.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source3/libsmb/clirap.c b/source3/libsmb/clirap.c
index 8124fc6f6cf..6a0dab37e7b 100644
--- a/source3/libsmb/clirap.c
+++ b/source3/libsmb/clirap.c
@@ -291,8 +291,7 @@ bool cli_NetServerEnum(struct cli_state *cli, char *workgroup, uint32_t stype,
 
 		res = PULL_LE_U16(rparam, 0);
 
-		if (res == 0 || res == ERRmoredata ||
-                    (res != -1 && cli_errno(cli) == 0)) {
+		if (res == 0 || res == ERRmoredata) {
 			char *sname = NULL;
 			int i, count;
 			int converter=SVAL(rparam,2);