From: Qinglang Miao Date: Fri, 20 Nov 2020 07:48:46 +0000 (+0800) Subject: memstick: fix a double-free bug in memstick_check X-Git-Tag: v4.14.213~136 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ba327081d8bdc40b2b4843fd852680f2dabfdd70;p=thirdparty%2Fkernel%2Fstable.git memstick: fix a double-free bug in memstick_check [ Upstream commit e3e9ced5c93803d5b2ea1942c4bf0192622531d6 ] kfree(host->card) has been called in put_device so that another kfree would raise cause a double-free bug. Fixes: 0193383a5833 ("memstick: core: fix device_register() error handling") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao Link: https://lore.kernel.org/r/20201120074846.31322-1-miaoqinglang@huawei.com Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- diff --git a/drivers/memstick/core/memstick.c b/drivers/memstick/core/memstick.c index b1564cacd19e1..20ae8652adf44 100644 --- a/drivers/memstick/core/memstick.c +++ b/drivers/memstick/core/memstick.c @@ -469,7 +469,6 @@ static void memstick_check(struct work_struct *work) host->card = card; if (device_register(&card->dev)) { put_device(&card->dev); - kfree(host->card); host->card = NULL; } } else