From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Date: Sun, 10 Nov 2019 11:06:58 +0000 (+0300)
Subject: vko: fix possible unitilized scalar access
X-Git-Tag: gnutls_3_6_11~13^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=baba4094a36fb2bac8fbb3dcdb6567194e1aee25;p=thirdparty%2Fgnutls.git

vko: fix possible unitilized scalar access

Fix error path in _gnutls_gost_keytrans_decrypt. If
_asn1_strict_der_decode() fails, cleanup path will try to
gnutls_pk_params_release(&pub), which will access unitialized pub
variable. Fix by deleting asn1 sctructure directly.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---

diff --git a/lib/vko.c b/lib/vko.c
index a419390ffa..f8aa80dfc7 100644
--- a/lib/vko.c
+++ b/lib/vko.c
@@ -197,7 +197,9 @@ _gnutls_gost_keytrans_decrypt(gnutls_pk_params_st *priv,
 	if (ret != ASN1_SUCCESS) {
 		gnutls_assert();
 		ret = _gnutls_asn2err(ret);
-		goto cleanup;
+		asn1_delete_structure(&kx);
+
+		return ret;
 	}
 
 	ret = _gnutls_get_asn_mpis(kx,