From: Naladala Ramanaidu Date: Fri, 17 Oct 2025 15:05:26 +0000 (+0530) Subject: drm/i915: Add fallback for CDCLK selection when min_cdclk is too high X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bbbfa70dfe00e78115474467903e28d6ac05be1f;p=thirdparty%2Fkernel%2Flinux.git drm/i915: Add fallback for CDCLK selection when min_cdclk is too high In cases where the requested minimum CDCLK exceeds all available values for the current reference clock, the CDCLK selection logic previously returned 0. This could result coverity division or modulo by zero issue. Introduce a fallback mechanism that returns platform's max_cdclk_freq instead of 0. v2: Update safe fallback value to max cdclk. (Ville) v3: Update commit messgae (Mika) Signed-off-by: Naladala Ramanaidu Reviewed-by: Mika Kahola Signed-off-by: Suraj Kandpal Link: https://patch.msgid.link/20251017150526.781715-1-ramanaidu.naladala@intel.com --- diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index e92e7fd9fd135..da97c38cca141 100644 --- a/drivers/gpu/drm/i915/display/intel_cdclk.c +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c @@ -1561,7 +1561,7 @@ static int bxt_calc_cdclk(struct intel_display *display, int min_cdclk) drm_WARN(display->drm, 1, "Cannot satisfy minimum cdclk %d with refclk %u\n", min_cdclk, display->cdclk.hw.ref); - return 0; + return display->cdclk.max_cdclk_freq; } static int bxt_calc_cdclk_pll_vco(struct intel_display *display, int cdclk)