From: Tim Golden Date: Tue, 12 Nov 2013 12:48:20 +0000 (+0000) Subject: Issue13674 Correct crash with strftime %y format under Windows X-Git-Tag: v3.4.0b1~311 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bbe268f58334ec87940094f18dd2e13d1ef2ca70;p=thirdparty%2FPython%2Fcpython.git Issue13674 Correct crash with strftime %y format under Windows --- bbe268f58334ec87940094f18dd2e13d1ef2ca70 diff --cc Lib/test/test_strftime.py index 6510c3669803,78c9c5bdb925..d3f80c6631ff --- a/Lib/test/test_strftime.py +++ b/Lib/test/test_strftime.py @@@ -177,5 -177,31 +177,31 @@@ class StrftimeTest(unittest.TestCase) print(" Expected %s, but got %s" % (e[1], result)) + class Y1900Tests(unittest.TestCase): + """A limitation of the MS C runtime library is that it crashes if + a date before 1900 is passed with a format string containing "%y" + """ + + @unittest.skipUnless(sys.platform == "win32", "Only applies to Windows") + def test_y_before_1900_win(self): + with self.assertRaises(ValueError): + time.strftime("%y", (1899, 1, 1, 0, 0, 0, 0, 0, 0)) + + @unittest.skipIf(sys.platform == "win32", "Doesn't apply on Windows") + def test_y_before_1900_nonwin(self): + self.assertEquals( + time.strftime("%y", (1899, 1, 1, 0, 0, 0, 0, 0, 0)), "99") + + def test_y_1900(self): + self.assertEquals( + time.strftime("%y", (1900, 1, 1, 0, 0, 0, 0, 0, 0)), "00") + + def test_y_after_1900(self): + self.assertEquals( + time.strftime("%y", (2013, 1, 1, 0, 0, 0, 0, 0, 0)), "13") + + def test_main(): + support.run_unittest(StrftimeTest, Y1900Tests) + if __name__ == '__main__': - test_main() + unittest.main()