From: Volker Lendecke <vl@samba.org>
Date: Wed, 15 Nov 2023 13:48:20 +0000 (+0100)
Subject: winbind: Fix Coverity ID 1398910
X-Git-Tag: talloc-2.4.2~582
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=bc0df4fd97a44dd69671b7faf8814307a552d400;p=thirdparty%2Fsamba.git

winbind: Fix Coverity ID 1398910

Coverity isn't smart enough for talloc

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/winbindd/winbindd_ads.c b/source3/winbindd/winbindd_ads.c
index d7a665abbc6..7e572e5d41f 100644
--- a/source3/winbindd/winbindd_ads.c
+++ b/source3/winbindd/winbindd_ads.c
@@ -449,6 +449,8 @@ static NTSTATUS query_user_list(struct winbindd_domain *domain,
 	rids = talloc_realloc(mem_ctx, rids, uint32_t, count);
 	if (prids != NULL) {
 		*prids = rids;
+	} else {
+		TALLOC_FREE(rids);
 	}
 
 	status = NT_STATUS_OK;